Conversation
… files and migrations
WalkthroughThis PR updates the build configuration system to target .NET 10.0 for tests, refactors MSBuild XML elements from multi-line to single-line formatting across multiple build files, adds csharpier ignore configuration template and patterns, and enhances editor configuration to handle generated code and migration files consistently. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~28 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/NetEvolve.Defaults/buildMultiTargeting/SupportAdditionalFiles.targets (1)
24-30: Inconsistent casing in property names.The property names use inconsistent casing for "CSharpier":
- Line 24-25:
CSharpierIgnoreSource,CSharpierIgnoreDest(capital S)- Lines 27-30:
CsharpierIgnoreCopyCommand(lowercase s)While MSBuild properties are case-insensitive, consistent naming improves readability and maintainability.
✏️ Suggested fix for consistent casing
- <CsharpierIgnoreCopyCommand Condition="'$(OS)' == 'Windows_NT'" - >pwsh -NoProfile -NonInteractive -Command "Copy-Item -Path '$(CSharpierIgnoreSource)' -Destination '$(CSharpierIgnoreDest)' -Force -ErrorAction SilentlyContinue"</CsharpierIgnoreCopyCommand + <CSharpierIgnoreCopyCommand Condition="'$(OS)' == 'Windows_NT'" + >pwsh -NoProfile -NonInteractive -Command "Copy-Item -Path '$(CSharpierIgnoreSource)' -Destination '$(CSharpierIgnoreDest)' -Force -ErrorAction SilentlyContinue"</CSharpierIgnoreCopyCommand > - <CsharpierIgnoreCopyCommand Condition="'$(OS)' != 'Windows_NT'">bash -c "cp -f '$(CSharpierIgnoreSource)' '$(CSharpierIgnoreDest)' 2>/dev/null || true"</CsharpierIgnoreCopyCommand> + <CSharpierIgnoreCopyCommand Condition="'$(OS)' != 'Windows_NT'">bash -c "cp -f '$(CSharpierIgnoreSource)' '$(CSharpierIgnoreDest)' 2>/dev/null || true"</CSharpierIgnoreCopyCommand>And update the Exec command on line 34:
- <Exec Command="$(CsharpierIgnoreCopyCommand)" ContinueOnError="true" IgnoreExitCode="true" /> + <Exec Command="$(CSharpierIgnoreCopyCommand)" ContinueOnError="true" IgnoreExitCode="true" />🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/NetEvolve.Defaults/buildMultiTargeting/SupportAdditionalFiles.targets` around lines 24 - 30, The property names are inconsistent: you should standardize the casing by renaming CsharpierIgnoreCopyCommand to CSharpierIgnoreCopyCommand (both Windows and non-Windows variants) so they match CSharpierIgnoreSource and CSharpierIgnoreDest; update any Exec/Task references that invoke CsharpierIgnoreCopyCommand to use CSharpierIgnoreCopyCommand so all related MSBuild properties and commands (CSharpierIgnoreSource, CSharpierIgnoreDest, CSharpierIgnoreCopyCommand) use consistent PascalCase.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.editorconfig:
- Around line 273-283: The analyzer severity setting is in the wrong section:
move the line `dotnet_analyzer_diagnostic.severity = none` out of the
`[*.{received,verified}.*]` block and place it under the
`[**/Migrations/*.{cs,csx,vb,vbx}]` block so that only migration files have
analyzers disabled; keep `generated_code = true` in both sections and ensure the
comment "Disable all style rules for migrations" sits with the migration
section.
---
Nitpick comments:
In `@src/NetEvolve.Defaults/buildMultiTargeting/SupportAdditionalFiles.targets`:
- Around line 24-30: The property names are inconsistent: you should standardize
the casing by renaming CsharpierIgnoreCopyCommand to CSharpierIgnoreCopyCommand
(both Windows and non-Windows variants) so they match CSharpierIgnoreSource and
CSharpierIgnoreDest; update any Exec/Task references that invoke
CsharpierIgnoreCopyCommand to use CSharpierIgnoreCopyCommand so all related
MSBuild properties and commands (CSharpierIgnoreSource, CSharpierIgnoreDest,
CSharpierIgnoreCopyCommand) use consistent PascalCase.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b64c214f-12a2-4937-9d55-a6695564f7a8
📒 Files selected for processing (16)
.csharpierignore.editorconfigDirectory.Build.propssrc/NetEvolve.Defaults/buildMultiTargeting/NetEvolve.Defaults.propssrc/NetEvolve.Defaults/buildMultiTargeting/NetEvolve.Defaults.targetssrc/NetEvolve.Defaults/buildMultiTargeting/SupportAdditionalFiles.targetssrc/NetEvolve.Defaults/buildMultiTargeting/SupportCopyright.targetssrc/NetEvolve.Defaults/buildMultiTargeting/SupportDetectContinuousIntegration.propssrc/NetEvolve.Defaults/buildMultiTargeting/SupportDetectContinuousIntegration.targetssrc/NetEvolve.Defaults/buildMultiTargeting/SupportGeneral.propssrc/NetEvolve.Defaults/buildMultiTargeting/SupportNuGetAudit.targetssrc/NetEvolve.Defaults/buildMultiTargeting/SupportPackageInformation.propssrc/NetEvolve.Defaults/buildMultiTargeting/SupportPackageInformation.targetssrc/NetEvolve.Defaults/buildMultiTargeting/SupportSystemRuntimeExperimental.targetssrc/NetEvolve.Defaults/configurations/template.csharpierignoresrc/NetEvolve.Defaults/configurations/template.editorconfig
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit