TUI: b to open services in browser #11687
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kpenfound <kyle@dagger.io>
TomChv
approved these changes
Jan 16, 2026
| // buffer raw logs so we can replay them later | ||
| db.PrimaryLogs[spanID] = append(db.PrimaryLogs[spanID], log) | ||
| } | ||
| // buffer raw logs so we can replay them later or extract structured data |
Member
There was a problem hiding this comment.
Can this change have any side effect on the current TUI?
Contributor
There was a problem hiding this comment.
Yeah - this will collect all log records for all spans into memory which is quite expensive; that's why we only did it for the primary span before.
I think we should instead change the engine to emit telemetry in a way that we can detect at ingestion time in the frontend (prettyLogs.Export), by looking for specific log attributes or something.
| return matches[1] | ||
| } | ||
| } | ||
| return "" |
Member
There was a problem hiding this comment.
Suggested change
| return "" | |
| return "" |
For consistency with you implementation further down
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2026-01-13.at.7.28.35.PM.mov