toolchains: dynamic checks for go and engine-dev #11686
Draft
+1,317
−441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the checks system to support dynamic checks from toolchains. Key changes: - Replace walkObjectChecks with ModTree abstraction for traversing module trees - Rename FnTreeNode to ModTreeNode with simplified structure - Add support for walking arrays of objects with +check methods - Add --all/-a flag to dagger check to enumerate dynamic checks - Include dynamic checks in aggregate listing even without --all - Fix TUI display for aggregate check execution - Add modtree path matching tests Signed-off-by: Solomon Hykes <solomon@dagger.io>
Add dynamic test enumeration to the Go toolchain using +check decorator. Changes: - Tests() returns []*TestDirectory grouped by directory - Each Test has a +check decorated Run() method - Use Source.Search() for fast regex-based test discovery - Pre-build container and share across tests via WithWorkdir() Signed-off-by: Solomon Hykes <solomon@dagger.io>
Add test splitting to engine-dev toolchain for parallel test execution. Changes: - Tests() returns []*TestDirectory with individual Test objects - Each Test has a +check decorated Run() method - TestNames() helper for debugging object construction performance - Preserved monolithic Test() function for backward compatibility Known issues: - Test container rebuilt per test (FIXME: share lazily) - Listing tests is slow due to eager object construction Signed-off-by: Solomon Hykes <solomon@dagger.io>
984e7e8 to
68ffc1e
Compare
67169f8 to
4936758
Compare
0e34028 to
75ff5ff
Compare
cd301a6 to
a75aca3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #11685, please merge that first
POC implementation of dynamic checks in our
goandengine-devtoolchains. This is still experimental and unfinsihed.dagger checkcan select individual test suites to run with standard check filtering syntaxgo test(note: too much overhead?)Changes
Go toolchain
Tests()returns[]*TestDirectorygrouped by directoryTesthas a+checkdecoratedRun()methodSource.Search()for fast regex-based test discoveryWithWorkdir()Engine-dev toolchain
Tests()returns[]*TestDirectorywith individualTestobjectsTesthas a+checkdecoratedRun()methodTestNames()helper for debugging object construction performanceTest()function for backward compatibilityKnown issues
Dependencies