core: allow exit codes >127 for ReturnType ANY and FAILURE #11666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nebojsa Jacovic <nebojsa.jacovic@gmail.com>
Author
|
Note: Happy to open a follow-up issue or PR to update this in the docs if that would be useful. |
shykes
approved these changes
Jan 14, 2026
Contributor
There was a problem hiding this comment.
Thanks for the contribution!
alexcb
reviewed
Jan 14, 2026
alexcb
reviewed
Jan 14, 2026
alexcb
reviewed
Jan 14, 2026
Signed-off-by: Nebojsa Jacovic <nebojsa.jacovic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11569
Summary
Allow ReturnType.ANY and ReturnType.FAILURE to accept exit codes 192–255, while preserving signal-related exclusions (128–191).
Testing
dagger call engine-dev test --pkg "./core/integration" --run "^TestReturnCodes$"
dagger call go lint