10BC0 Fix isolate outer si typing by wclr · Pull Request #950 · cyclejs/cyclejs · GitHub
[go: up one dir, main page]
Skip to content

Fix isolate outer si typing #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix isolate outer si typing #950

wants to merge 6 commits into from

Conversation

wclr
Copy link
Contributor
@wclr wclr commented Aug 29, 2020
  • There exists an issue discussing the need for this PR
  • I added new tests for the issue I fixed or built
  • I used pnpm run commit instead of git commit
  const X = (s: { DOM: MainDOMSource }) => {
    return {
      DOM: xs.of(img()),
    }
  }

const IsolatedX = isolate(X)
const x =  IsolatedX({ DOM })
// now x.DOM  is Stream<VNode> instead of Stream<any>
x.DOM.map((vnode) => vnode.children)

@wclr
Copy link
Contributor Author
wclr commented Aug 31, 2020

The with isolate with typings also refers to staltz/xstream#306
as I'm using a distinct version of MemoryStream type which Stream is not assignable to.

@staltz
So I'm not proposing to merge this PR as there may be other issues related to this, but want to draw your attention, to that isolate tyings actually does not work correctly now and using explicit any in public API like here, in this case, is not a very good thing.

PR #949 actually fixes this issue with isolating DOM sink with current DOM driver without need of this PR.

@wclr wclr mentioned this pull request Aug 31, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@0racl3z 0racl3z 0racl3z approved these changes

Reviewers whose approvals may not 4F53 affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wclr @0racl3z
0