[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix proxy cutoff detection #5994

Closed
wants to merge 2 commits into from
Closed

Fix proxy cutoff detection #5994

wants to merge 2 commits into from

Conversation

bagder
Copy link
Member
@bagder bagder commented Sep 22, 2020

Fixes #5992

@bagder
http_proxy: do not count proxy headers in the header bytecount
4ae8059 
... as that counter is subsequently used to detect if nothing was
returned from the peer. This made curl return CURLE_OK when it should
have returned CURLE_GOT_NOTHING.

Fixes #5992
Reported-by: Tom van der Woerdt
@bagder
test1297: verify GOT_NOTHING with http proxy tunnel
64d4695
@TvdW
Copy link
TvdW commented Sep 22, 2020 
>
* Empty reply from server
* Connection #0 to host [proxy] left intact
curl: (52) Empty reply from server

Much better :) Thanks!

@bagder bagder closed this in e580308 Sep 22, 2020
@bagder bagder deleted the bagder/proxy-cutoff branch September 22, 2020 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
connecting & proxies
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proxy-level timeout as FIN is not handled as error
2 participants
@bagder @TvdW