8000 bugfix: Add new matroska MIME types by EdwardBetts · Pull Request #759 · ctalkington/python-rokuecp · GitHub
[go: up one dir, main page]
Skip to content

bugfix: Add new matroska MIME types #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ctalkington merged 1 commit into from
Jun 6, 2025
Merged

bugfix: Add new matroska MIME types #759

ctalkington merged 1 commit into from
Jun 6, 2025

Conversation

@EdwardBetts
Copy link
Contributor
@EdwardBetts EdwardBetts commented Mar 27, 2025

The mime types audio/x-matroska and video/x-matroska have been deprecated and replaced with audio/matroska video/matroska. This change fixes a test failure on Debian sid.

See https://salsa.debian.org/debian/media-types/-/commit/0e6a959c8ac22b0516f620467a57d3968097a323

@EdwardBetts
Add new matroska MIME types
d881175 
The mime types audio/x-matroska and video/x-matroska have been deprecated and replaced with audio/matroska video/matroska. This change fixes a test failure on Debian sid.

See 
https://salsa.debian.org/debian/media-types/-/commit/0e6a959c8ac22b0516f620467a57d3968097a323
@EdwardBetts EdwardBetts changed the title Add new matroska MIME types bugfix: Add new matroska MIME types Mar 27, 2025
@EdwardBetts
Copy link
Contributor Author
EdwardBetts commented Mar 27, 2025

Fixes this test failure.

============================= test session starts ==============================
platform linux -- Python 3.13.2, pytest-8.3.5, pluggy-1.5.0
rootdir: /home/edward/src/2025/vendor/python-rokuecp
configfile: pyproject.toml
plugins: cov-5.0.0, requests_mock-1.12.1, anyio-4.8.0, aresponses-3.0.0, asyncio-0.25.1, mock-3.14.0, syrupy-4.8.1, time-machine-2.16.0, pytest_freezer-0.4.9, xvfb-3.0.0, xdist-3.6.1, tornasync-0.6.0.post2, hypothesis-6.127.4, typeguard-4.4.2, Faker-33.3.1, kgb-7.2, respx-0.22.0
asyncio: mode=Mode.AUTO, asyncio_default_fixture_loop_scope=None
collected 74 items

tests/test_client.py ..............                                      [ 18%]
tests/test_helpers.py .F....                                             [ 27%]
tests/test_interface.py .................................                [ 71%]
tests/test_models.py .....................                               [100%]

=================================== FAILURES ===================================
___________________________ test_guess_stream_format ___________________________

    def test_guess_stream_format() -> None:
        """Test the guess_stream_format helper."""
        assert guess_stream_format("/path/media.media") is None
        assert guess_stream_format("/path/media.txt") is None
    
        assert guess_stream_format("/path/media.mp4", "video/mp4") == "mp4"
        assert guess_stream_format("/path/media.mp4") == "mp4"
        assert guess_stream_format("/path/media.m4v") == "mp4"
        assert guess_stream_format("/path/media.mov") == "mp4"
>       assert guess_stream_format("/path/media.mkv") == "mkv"
E       AssertionError: assert None == 'mkv'
E        +  where None = guess_stream_format('/path/media.mkv')

tests/test_helpers.py:41: AssertionError
=========================== short test summary info ============================
FAILED tests/test_helpers.py::test_guess_stream_format - AssertionError: asse...
========================= 1 failed, 73 passed in 1.36s =========================

@EdwardBetts EdwardBetts mentioned this pull request Mar 29, 2025
Closed
@ctalkington ctalkington added the bugfix Inconsistencies or issues which will cause a problem for users or implementers. label Jun 6, 2025
@ctalkington ctalkington merged commit 5b642e0 into ctalkington:main Jun 6, 2025
0 of 2 checks passed
@EdwardBetts EdwardBetts deleted the patch-1 branch June 6, 2025 22:44
@cdce8p
Copy link
Contributor
cdce8p commented Jun 12, 2025

Hi @ctalkington 👋🏻 Could you do a new release with this change? It will also be required for compatibility with Python 3.14. See python/cpython#126412. Would be awesome to have a fix available early.

@ctalkington
Copy link
Owner
ctalkington commented Jun 14, 2025

https://pypi.org/project/rokuecp/0.19.5/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bugfix Inconsistencies or issues which will cause a problem for users or implementers.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@EdwardBetts @cdce8p @ctalkington
0