8000 Added class in DefinitionDecorator, as it breaks with Symfony < 2.8. by csarrazi · Pull Request #120 · csarrazi/CsaGuzzleBundle · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Jul 15, 2021. It is now read-only.

Added class in DefinitionDecorator, as it breaks with Symfony < 2.8. #120

Merged
merged 2 commits into from
Jan 21, 2016
Merged

Added class in DefinitionDecorator, as it breaks with Symfony < 2.8. #120

merged 2 commits into from
Jan 21, 2016

Conversation

csarrazi
Copy link
Owner

Fixes #118

@csarrazi csarrazi added the bug label Jan 21, 2016
@csarrazi csarrazi self-assigned this Jan 21, 2016
@xabbuh
Copy link
Contributor
xabbuh commented Jan 21, 2016

👍 looks weird to me that this works without any issue on Symfony 2.8

@csarrazi
Copy link
Owner Author

@xabbuh Indeed, this is really, really weird...

csarrazi added a commit that referenced this pull request Jan 21, 2016
@csarrazi
Merge pull request #120 from csarrazi/fix/118
e174ab8 
Added class in DefinitionDecorator, as it breaks with Symfony < 2.8.
@csarrazi csarrazi merged commit e174ab8 into 2.0 Jan 21, 2016
@csarrazi csarrazi deleted the fix/118 branch January 21, 2016 13:03
@csarrazi csarrazi mentioned this pull request Jan 21, 2016
Closed
@jakzal
Copy link
jakzal commented Jan 21, 2016

The reason for this is 2.7 ignores abstract definitions, while 2.8 does not. The change was introduced in symfony/symfony#15096.

@csarrazi
Copy link
Owner Author

Thanks @jakzal!

@xabbuh xabbuh mentioned this pull request Jan 21, 2016
Closed
@SofHad SofHad mentioned this pull request Jan 28, 2016
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@csarrazi csarrazi

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@csarrazi @xabbuh @jakzal
0