Fix missing recurring calendar after update #1936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Events to render on the current month weren't taking into account the "day" modification of recurring events, resulting in some events not being displayed until the user loaded other months.
Example: We have an event repeating every two weeks and, at some point, we delay future occurrences by one week. If an event was supposed to occur on the last week of a month, it will now occur on the first week of the next month.
Our code was computing the events to render on a given month before updating the events with their time adjustment, meaning that in this example, the event that shifted its month wouldn't be rendered until the user computed both months (by moving back in the calendar view).