Fixed a compiler optimisation bug in tests #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
522eac0 to
6f70bd5
Compare
The global flag must_finish is set by an alarm handler and continuously
checked in a while loop:
do {
...
} while(must_finish==0);
Some compilers may optimize this loop if must_finish is not declared as
volatile.
Tested with:
Compiler: GCC 11.3
Target: 32bit ARM cortex-a9
Optimization: -O2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added 'volatile' to sha_speed test's must_finish global variable since it otherwise may be optimized by the compiler in the following loop in hash_data:
Compiler: GCC 11.3
Target: 32bit ARM cortex-a9
Optimization: -O2