Add new convenience token methods #392
Conversation
test/token/token.test.ts
Outdated
| // Ensure this prop is removed | ||
| jti: undefined, |
There was a problem hiding this comment.
There is no logic for this in the method
There was a problem hiding this comment.
Nice catch! I was just testing to see if you were paying attention to the review 👀
Did you know that in Jest, the assertion expect({foo: true}).toEqual({foo: true, bar: undefined}) is considered true? It's a bad design decision, but they realized it too late to make a change without breaking existing code. So, they introduced a new assertion called toStrictEqual that behaves as we would expect. It's similar to the difference between === and ==== operators in JavaScript.
|
Code Climate has analyzed commit 0d9a095 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 99.9% (0.0% change). View more on Code Climate. |
Summary
This pull request adds new convenient methods to the
Tokenclass to make handling easier.Checklist