[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on API key #386

Merged
merged 1 commit into from
May 6, 2024
Merged

Remove dependency on API key #386

merged 1 commit into from
May 6, 2024

Conversation

marcospassos
Copy link
Member

Summary

This PR removes the dependency on API keys for Evaluator and Content Fetch as they require a crypto functionality not available on browsers.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@marcospassos marcospassos added the bug Something isn't working label May 6, 2024
@codeclimate CodeClimate
Copy link
codeclimate bot commented May 6, 2024

Code Climate has analyzed commit 329b641 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 99.9% (0.0% change).

View more on Code Climate.

Fryuni
Fryuni approved these changes May 6, 2024
View reviewed changes
src/contentFetcher.ts Show resolved Hide resolved
@marcospassos marcospassos merged commit a2144d1 into master May 6, 2024
6 checks passed
@marcospassos marcospassos deleted the fix-import branch May 6, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fryuni Fryuni Fryuni approved these changes

@renan628 renan628 renan628 approved these changes

@denis-rossati denis-rossati denis-rossati approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marcospassos @Fryuni @renan628 @denis-rossati