8000 Hotfix 30 by webremote · Pull Request #37 · craftapi/htmlcache · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@webremote
Copy link
Contributor
@webremote webremote commented Dec 13, 2016
  • should fix CSS styles aren't loaded #30
  • documented and improved the htmlcache_filename function
  • improved htmlcache_checkCache function by respecting settings.json file, improvements for v1.1 marked
    • disableHeaders (default false)
    • defaultMimetype (default text/html)
    • defaultMimetypeCharset (default UTF-8)
    • enableFootprint (default false)

* should fix #30 
* documented and improved the `htmlcache_filename` function
* improved `htmlcache_checkCache` function by respecting `settings.json` file, improvements for v1.1 marked
* * `disableHeaders` (default `false`)
* * `defaultMimetype` (default `text/html`)
* * `defaultMimetypeCharset` (default `UTF-8`)
* * `enableFootprint` (default `false`)
@KoenRijpstra
Copy link
Contributor
< 8000 h3 class="f5 text-normal py-2" style="flex: 1 1 auto">

This doesn't seem right. In my opinion this plugin should never cache the following files 'css', 'js','jpg', 'jpeg', 'gif', 'bmp', 'png'. It looks like there is something wrong with the server/craft config in issue #30.

@webremote
Copy link
Contributor Author

not going to merge

@webremote webremote closed this Dec 26, 2016
@webremote webremote deleted the hotfix-30 branch December 26, 2016 09:09
@webremote webremote restored the hotfix-30 branch December 26, 2016 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CSS styles aren't loaded

3 participants

0