Fix 2SAT.md #1274
Fix 2SAT.md #1274
Conversation
The existing code didn't work out of the box, and `n` was used for two different numbers
|
Visit the preview URL for this PR (for commit 2fb1fdb): https://cp-algorithms--preview-1274-jjsiblvx.web.app (expires 2024-06-16T00:24:50.174049353Z) |
There was a problem hiding this comment.
Thanks for the pull request! Please note that the code that you are changing is also covered by test_2sat.cpp. Could you please also fix either the code in the article, or the test itself, so that they're compatible with each other?
Also it would be great if you could also add a test to test_2sat.cpp, in which the old implementation would fail, but the new one wouldn't.
|
The old implementation is correct, but the way to use it in code did not correspond to my intuitive guess. I added the |
|
Visit the preview URL for this PR (for commit a45e808): https://cp-algorithms--preview-1274-jyfbqry4.web.app (expires 2024-06-26T16:27:58.407608721Z) |
|
Thanks! |
The existing code didn't work out of the box, and
nwas used for both the number of variables and the number of vertices in the graph.