8000 UI: Special case landing page of 4 .card-box by osfameron · Pull Request #190 · couchbase/docs-ui · GitHub
[go: up one dir, main page]

Skip to content

UI: Special case landing page of 4 .card-box #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Conversation

osfameron
Copy link
Contributor

Request via @RichardSmedley to make e.g. this page https://preview.docs-test.couchbase.com/sdk-test/home/developer-docs.html show as 2x2 rather than 3+1 when stretched to widest setting.

PR approach is to give an override of width for a list with a 4th item, and then another override for a list with a 5th item.
e.g. the intent is to special-case only 4 cards.

Is this sensible/silly?

Copy link
Contributor
@RayOffiah RayOffiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's pretty clever!

Copy link
Contributor
@RichardSmedley RichardSmedley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it - thanks @osfameron

@osfameron osfameron merged commit aea60c9 into master Feb 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0