10000 HeaderDropdown refactor by xidedix · Pull Request #5 · coreui/coreui-vue · GitHub
[go: up one dir, main page]
Skip to content

HeaderDropdown refactor #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 4, 2018
Merged

HeaderDropdown refactor #5

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6d3a146
chore(Aside): cleanup
xidedix Jun 4, 2018
86f9c17
refactor(HeaderDropdown): add slots: header, dropdown, cleanup
xidedix Jun 4, 2018
c1c6a8d
chore: dependencies update
xidedix Jun 4, 2018
6076a96
chore(release): v2.0.0-beta.1
xidedix Jun 4, 2018
df8c3f6
chore(README): add npm link
xidedix Jun 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore(Aside): cleanup
  • Loading branch information
@xidedix
xidedix committed Jun 4, 2018
commit 6d3a1469c5176abfcc8f664fb3d94494525febac
10 changes: 0 additions & 10 deletions src/components/Aside/Aside.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@
</template>

<script>
// import { asideMenuCssClasses, validBreakpoints, checkBreakpoint } from '../../shared/classes'

export default {
name: 'AppAside',
props: {
Expand All @@ -26,7 +24,6 @@ export default {
mounted: function () {
this.isFixed(this.fixed)
this.isOffCanvas(this.offCanvas)
// this.displayBreakpoint(this.display)
},
methods: {
isFixed (fixed) {
Expand All @@ -36,13 +33,6 @@ export default {
isOffCanvas (offCanvas) {
offCanvas ? document.body.classList.add('aside-menu-off-canvas') : document.body.classList.remove('aside-menu-off-canvas')
}
// displayBreakpoint (display) {
// let cssClass = asideMenuCssClasses[0]
// if (display && checkBreakpoint(display, validBreakpoints)) {
// cssClass = `aside-menu-${display}-show`
// }
// document.body.classList.add(cssClass)
// }
}
}
</script>
0