8000 Update tests by mrholek · Pull Request #423 · coreui/coreui-react · GitHub
[go: up one dir, main page]
Skip to content

Update tests #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 3, 2025
Merged

Update tests #423

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c54a0ab
chore: update dependencies and devDependencies
mrholek Jan 2, 2025
36814f6
chore: update dependencies and devDependencies
mrholek Jan 2, 2025
c2d2e7d
fix: lock the version of `@types/prop-types` to prevent `children` pr…
mrholek Jan 2, 2025
b1ede20
tests: update tests
mrholek Jan 3, 2025
e457ffe
fix(CModal): disable emitting the `onClose` event twice
mrholek Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(CModal): disable emitting the onClose event twice
  • Loading branch information
@mrholek
mrholek committed Jan 3, 2025
commit e457ffe325d1a91e5e4f36ebd00870edaaacc953
3 changes: 1 addition & 2 deletions packages/coreui-react/src/components/modal/CModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,13 +158,12 @@ export const CModal = forwardRef<HTMLDivElement, CModalProps>(
}, [_visible])

const handleDismiss = () => {
console.log('handleDismiss')
if (backdrop === 'static') {
return setStaticBackdrop(true)
}

setVisible(false)

return onClose && onClose()
}

useLayoutEffect(() => {
Expand Down
0