8000 Build and test for Windows on ARM by QuLogic · Pull Request #476 · contourpy/contourpy · GitHub
[go: up one dir, main page]
Skip to content

Build and test for Windows on ARM #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2025
Merged

Build and test for Windows on ARM #476

merged 1 commit into from
Jun 6, 2025
+11 −1

Conversation

QuLogic
Copy link
Contributor
@QuLogic QuLogic commented Jun 5, 2025

cf matplotlib/matplotlib#28554 (comment) this does appear to build fine already. Will have to see how tests go.

@QuLogic
Copy link
Contributor Author
QuLogic commented Jun 5, 2025

Strange, the build failed to find python3.13t.lib even though that wasn't reference in the linker line. I wonder if the wrong headers are being picked up somehow.

In any case, to avoid that problem, I switched the Windows ARM test build to Python 3.12 instead (which matches the Win32 one, too.)

@finnagin
Copy link
finnagin commented Jun 5, 2025

Strange, the build failed to find python3.13t.lib even though that wasn't reference in the linker line. I wonder if the wrong headers are being picked up somehow.

In any case, to avoid that problem, I switched the Windows ARM test build to Python 3.12 instead (which matches the Win32 one, too.)

I think this may be due to python/cpython#135151

@QuLogic
Copy link
Contributor Author
QuLogic commented Jun 5, 2025

Oh, possibly; it looks like the ARM runners had 3.13.4, but the AMD64 runners were still on 3.13.3.

@QuLogic
Copy link
Contributor Author
QuLogic commented Jun 5, 2025

It looks like we've reached the bootstrap problem that matplotlib doesn't have wheels, but we are at a sufficient point to enable them, so this can wait for matplotlib/matplotlib#28554

@ianthomas23
Copy link
Member

Thanks for doing this. I suggest we disable image testing (so mpl isn't required) to get this merged, then I can re-add it later. That would involve setting test-no-images: true like here:
https://github.com/contourpy/contourpy/blob/328ba771e89cf4f9ab0819d04c269e5845594ff4/.github/workflows/test.yml#L108C13-L108C33

ianthomas23
ianthomas23 approved these changes Jun 6, 2025
View reviewed changes
Copy link
Member
@ianthomas23 ianthomas23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

I'll manually start a nightly wheel build to see how that goes.

@ianthomas23 ianthomas23 merged commit 83f3873 into contourpy:main Jun 6, 2025
46 checks passed
@QuLogic QuLogic deleted the winarm branch June 6, 2025 07:50
@ianthomas23
Copy link
Member

The nightly wheel build needs a change, I'll deal with it.

@ianthomas23 ianthomas23 mentioned this pull request Jun 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianthomas23 ianthomas23 ianthomas23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @finnagin @ianthomas23
0