[RFC] change lock file directory #1605
Conversation
|
I like the idea. @contao/developers What about you? |
|
I don't like this. I would rather have a general |
|
One reason not to do it would be because then the users would be able to shoot himself in the foot by deleting one or all lock files while they are needed ;) |
|
Related: symfony/symfony#23354 |
|
I’m not sure if I should like this. If I understood the linked issue about Strato correctly, it was about opening the file handle with write permissions and setting the correct file rights. Wouldn’t these issues have been the same in the As @Toflar already wrote in #1551 (comment) other dependencies might rely on IMO if
This could also be fixed by changing the hash to |
|
Given that symfony/symfony#27903 has been merged, this ticket can be closed. |
Due to the ongoing problems with the
AbstractLockedCommandon Strato, I propose at least the following change: use a/var/locksdirectory within the project instead of thesys_get_temp_dir()location.Since we need a read and write file handle for file locks on Solaris, the file permissions of the lock files need to be changed from
0444to0666(see symfony/symfony#27903). Any lock files generated prior to this change will still cause problems. Thus, if the lock files are at least within the user's reach (i.e. in the project directory) such errors would be easier to handle.Also there is a small bug in PHP that causes the
sys_get_temp_dir()function to return the temp path with a trailing slash on Solaris. So all the lock file paths will contain a double slash. But this is just a cosmetic discrepancy and doesn't affect the functionality.