8000 [RFC] Make all services public that we are retrieving directly from the container by sheeep · Pull Request #1383 · contao/core-bundle · GitHub
[go: up one dir, main page]
Skip to content

[RFC] Make all services public that we are retrieving directly from the container #1383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 2, 2018
Merged

[RFC] Make all services public that we are retrieving directly from the container #1383

merged 3 commits into from
Mar 2, 2018

Conversation

sheeep
Copy link
Member
@sheeep sheeep commented Feb 19, 2018

I searched the Contao source code for instances of getContainer()->get('...'); occurrences, filtered out contao prefixed services and "uniquified" the resulting array.

assets.packages
database_connection
doctrine.dbal.default_connection
event_dispatcher
filesystem
fragment.handler
lexik_maintenance.driver.factory
monolog.logger.contao
request_stack
router
security.authentication_utils
security.authorization_checker
security.firewall.map
security.logout_url_generator
security.token_storage
session
swiftmailer.mailer
translator

After intersecting this array to the one found in this ticket (future public services) this ticket, we end up with:

assets.packages
database_connection
doctrine.dbal.default_connection
fragment.handler
lexik_maintenance.driver.factory
monolog.logger.contao
security.firewall.map
security.logout_url_generator
swiftmailer.mailer

I added those to our MakeServicesPublicPass and made sure it will also find aliases instead of definitions only.

Unfortunately I'm not sure if I really caught all direct service references. Do you have any other ideas?

@leofeyer
Copy link
Member

I think if we merge #1381, we also need security.authentication.trust_resolver, don't we?

@leofeyer leofeyer added this to the 4.6.0 milestone Feb 19, 2018
@leofeyer leofeyer merged commit b813235 into contao:master Mar 2, 2018
@leofeyer
Copy link
Member
leofeyer commented Mar 2, 2018

Thank you @sheeep.

leofeyer added a commit to contao/installation-bundle that referenced this pull request Jun 25, 2018
@leofeyer
Make services public that we are retrieving directly from the contain…
1b43e8b 
…er (see contao/core-bundle#1383)
christian-kolb pushed a commit to christian-kolb/contao that referenced this pull request Oct 11, 2018
@leofeyer
[Installation] Make services public that we are retrieving directly f…
c21022d 
…rom the container (see contao/core-bundle#1383)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sheeep sheeep

Labels
feature
Projects
None yet
Milestone
4.6
Development

Successfully merging this pull request may close these issues.
2 participants
@sheeep @leofeyer
0