8000 Revert "Use real path for `.env.local`" by fritzmg · Pull Request #6172 · contao/contao · GitHub
[go: up one dir, main page]
Skip to content

Revert "Use real path for .env.local" #6172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Revert "Use real path for .env.local" #6172

wants to merge 2 commits into from

Conversation

fritzmg
Copy link
Contributor
@fritzmg fritzmg commented Jun 26, 2023

Now that Symfony 5.4.25 and 6.2.12 have been released, we can revert the usage of realpath again (#6066), as this has been fixed in symfony/symfony#50437

This PR reverts the realpath usage, increases the symfony/filesystem dependency accordingly and keeps the symlink test from #6066.

@fritzmg fritzmg added the bug label Jun 26, 2023
@fritzmg fritzmg added this to the 4.13 milestone Jun 26, 2023
@fritzmg fritzmg requested review from ausi and leofeyer June 26, 2023 08:38
@fritzmg fritzmg self-assigned this Jun 26, 2023
@fritzmg fritzmg marked this pull request as ready for review June 26, 2023 08:38
@fritzmg
Copy link
Contributor Author
fritzmg commented Jun 26, 2023

lol, duplicate of #6171 😁

@fritzmg fritzmg closed this Jun 26, 2023
@fritzmg fritzmg deleted the revert-dotenv-realpath branch June 26, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ausi ausi Awaiting requested review from ausi

@leofeyer leofeyer Awaiting requested review from leofeyer leofeyer is a code owner

Assignees

@fritzmg fritzmg

Labels
bug
Projects
None yet
Milestone
4.13
Development

Successfully merging this pull request may close these issues.
1 participant
@fritzmg
0