Make host-device to work with virtio net device #453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case pciBusID contains pci address of the virtio device, then lookup the net directory under virtio<id> directory. Issue: containernetworking#320 Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
|
lgtm I guess... |
jellonek
approved these changes
Feb 13, 2020
@jellonek and @dcbw thanks for the feedback. @jellonek how do you want to test it ? I've tested the fix via device plugin and multus which were configured to pass virtio interface PCI address as |
|
I think that the only way to test that would be to turn sysBusPCI from const to a variable (with possibility to change it's value from test package, so by turning it into exported variable or by adding a helper fuc to set its value), which then could be mocked in test passing a manually prepared directory with expected entries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case pciBusID contains pci address of the virtio device, then lookup
ip linkunder{sysBusPCIDir}/virtio{id}/netdirectory.Issue: #320
Signed-off-by: Periyasamy Palanisamy periyasamy.palanisamy@est.tech