10000 Return Err on Confirm's read_key when not a terminal by DanteMarshal · Pull Request #229 · console-rs/dialoguer · GitHub
[go: up one dir, main page]
Skip to content

Return Err on Confirm's read_key when not a terminal #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2023
Merged

Return Err on Confirm's read_key when not a terminal #229

merged 1 commit into from
Jan 14, 2023

Conversation

DanteMarshal
Copy link
Contributor

Resolves #148

pksunkara
pksunkara reviewed Nov 9, 2022
View reviewed changes
Copy link
Collaborator
@pksunkara pksunkara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this leafs to other issues as discussed a few months ago.

@DanteMarshal
Copy link
Contributor Author

What are these issues ?

@mitsuhiko mitsuhiko merged commit a6659ce into console-rs:master Jan 14, 2023
@pksunkara pksunkara mentioned this pull request May 21, 2023
Merged
@mitsuhiko mitsuhiko mentioned this pull request May 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pksunkara pksunkara pksunkara left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confirm::_interact_on infinite loop when not a tty
3 participants
@DanteMarshal @pksunkara @mitsuhiko
0