fix: also reset self.prompt_height in TermThemeRenderer::clear.
#191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, calling clear the next time will call prompt_height lines too many.
|
There's a simple "manual test case": apply the following patch on top of the change and execute any confirmation prompt. diff --git a/src/prompts/confirm.rs b/src/prompts/confirm.rs
--- a/src/prompts/confirm.rs
+++ b/src/prompts/confirm.rs
@@ -237,6 +237,10 @@ impl Confirm<'_> {
term.clear_line()?;
if self.report {
render.confirm_prompt_selection(&self.prompt, rv)?;
+ render.clear()?;
+ render.clear()?;
+ render.confirm_prompt_selection(&self.prompt, rv)?;
+
}
term.show_cursor()?;
term.flush()?;
diff --git a/src/theme.rs b/src/theme.rs
--- a/src/theme.rs
+++ b/src/theme.rs
@@ -843,7 +843,7 @@ impl<'a> TermThemeRenderer<'a> {
self.term
.clear_last_lines(self.height + self.prompt_height)?;
self.height = 0;
- self.prompt_height = 0;
+ //self.prompt_height = 0;
Ok(())
}Run a simple prompt, e.g. the following (in a crate with dialoguer as dependency) fn main() -> std::io::Result<()> {
dialoguer::Confirm::new().with_prompt("prompt string").interact()?;
}Actual behaviour. The prompt string and lines before it are cleared. Making the prompt string longer exerbates this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears like an oversight: we clear the last
self.height+self.prompt_heightlines from the output; we setheightto 0, but notprompt_height. We should also reset prompt_height.This can cause issues if we were to call clear() twice in a row: we would clear prompt_height lines more than we should.