8000 Extend and tweak documention in select.rs and theme.rs. by grunweg · Pull Request #177 · console-rs/dialoguer · GitHub
[go: up one dir, main page]
Skip to content

Extend and tweak documention in select.rs and theme.rs. #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Extend and tweak documention in select.rs and theme.rs. #177

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
332c49e
Two typo fixes.
grunweg Jan 20, 2022 8000
9c9ed0e
doc: use imperative tense more in render.rs.
grunweg Feb 14, 2022
86ebe75
doc: Use imperative tense in select.rs.
grunweg Feb 14, 2022
7426264
doc: Reword some doc comments in select.rs.
grunweg Feb 14, 2022
c2cc7c5
doc: minor and grammar improvements in theme.rs.
grunweg Feb 14, 2022
0d28b43
Document some members in select.rs.
grunweg Feb 14, 2022
684a08a
doc: use imperative tense more in confirm.rs.
grunweg May 5, 2022
cdbab55
doc: copy-edit some doc comments in confirm.rs.
grunweg May 5, 2022
13a2153
doc: Document members of the Confirm struct.
grunweg May 5, 2022
1875fe5
doc: Use imperative tense more in theme.rs.
grunweg May 5, 2022
537fd91
doc: use imperative tense in password.rs.
grunweg May 5, 2022
623acf8
doc: document members of password.rs.
grunweg May 5, 2022
7827056
doc: document four functions in theme.rs.
grunweg May 5, 2022
497de38
refactor: use prompts_reset_heights=true in password prompt.
grunweg May 5, 2022
f1dfaa1
refactor: remove prompts_reset_height: it's always true now.
grunweg May 5, 2022
cb1ae52
doc: document meaning of height and prompt_height in TermThemeRenderer.
grunweg May 6, 2022
14a70e1
Merge branch 'master' into more-docs
grunweg May 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Two typo fixes.
  • Loading branch information
@grunweg
grunweg committed Jan 20, 2022
commit 332c49e024daa2b4395d09979ca139a9521d3a2a
2 changes: 1 addition & 1 deletion src/prompts/sort.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ impl Sort<'_> {

/// Sets an optional max length for a page
///
/// Max length is disabled by None
/// Max length is disabled by `None`
pub fn max_length(&mut self, val: usize) -> &mut Self {
// Paging subtracts two from the capacity, paging does this to
// make an offset for the page indicator. So to make sure that
Expand Down
2 changes: 1 addition & 1 deletion src/theme.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,7 +619,7 @@ impl Theme for ColorfulTheme {
}
}

/// Helper struct to conveniently render a theme ot a term.
/// Helper struct to conveniently render a theme to a term 481B .
pub(crate) struct TermThemeRenderer<'a> {
term: &'a Term,
theme: &'a dyn Theme,
Expand Down
0