Master for 0.20.0 final #73
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
recipe/meta.yaml
Outdated
|
|
||
| build: | ||
| number: 201 | ||
| number: 1 |
There was a problem hiding this comment.
This should be 200.
There was a problem hiding this comment.
I believe you. That doc could use a short paragraph of introduction though...
There was a problem hiding this comment.
That's fair. It was originally a spec Phil Elson and I drafted. Agree it could be more user friendly. Feel free to add an issue or PR on the webpage repo with some suggestions.
recipe/meta.yaml
Outdated
| @@ -1,4 +1,4 @@ | |||
| {% set version = "0.19.2" %} | |||
| {% set version = "0.20" %} | |||
recipe/meta.yaml
Outdated
| imports: | ||
| - sklearn | ||
| commands: | ||
| - nosetests sklearn --exe | ||
| - pytest --pyargs sklearn | ||
| - conda inspect linkages -p $PREFIX scikit-learn # [not win] | ||
| - conda inspect objects -p $PREFIX scikit-learn # [osx] |
There was a problem hiding this comment.
We can drop the conda inspect lines as conda-build does this for us now. Plus those commands will soon be deprecated and removed.
| @@ -0,0 +1,18 @@ | |||
| <!-- | |||
There was a problem hiding this comment.
Hmm...so a bunch of files appear to have been added like this one. 😕 Guessing this came from a bad re-rendering. Can take a look locally and push a fix if you would like.
|
thanks for your quick help :) |
Travis CI builds are running into log length limits, which are causing the macOS builds there to fail. It's very hard to "fix" the builds to stay within this log length limit and arguably not worth the effort. Given this, simply switch macOS builds to CircleCI where the constraints are generally more reasonable.
Now that CircleCI is being used for macOS builds, re-render to update the CIs accordingly. Namely disabling Travis CI and adding the matrix builds for macOS to CircleCI.
|
Travis CI builds were failing as they reached the log length limit. Instead of trying to figure out how to keep these builds within this arbitrary limit, have just opted to move the macOS builds to CircleCI. Pushed these changes to your PR. Hope that is ok. |
|
Sounds good, I trust your judgement on this :) |
|
Feel free to merge when you are ready. |
|
Thanks for making it happen! Though, let's not merge this until it is decided what should be done regarding 0.20.X backports in scikit-learn/scikit-learn#12151 (comment) |
|
change the sha for the new tag... this is an interesting thing to do lol |
Trying to finally release 0.20.0