8000 WIP: 3.8.0b3 by jjhelmus · Pull Request #271 · conda-forge/python-feedstock · GitHub
[go: up one dir, main page]
Skip to content

WIP: 3.8.0b3 #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

WIP: 3.8.0b3 #271

wants to merge 5 commits into from

Conversation

jjhelmus
Copy link
Contributor

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Python 3.8.0b3 based off @mingwandroid's work in #268.

Still a work in progress, still needs:

  • updates to the _sysconfig... files
  • additional incorporation from 3.8 #268
  • build changes from the Python 3.7.4 recipe from AnacondaRecipes
  • adjustments to upload packages to the pre-3.8 label on the conda-forge channel.

@jjhelmus
update patches
57d5413 
reworked patches taken from PR conda-forge#268, thanks @mingwandroid

Drop
0003-Win32-distutils-Also-look-for-executable.bat.patch
0015-Fix-cross-compilation-on-Debian-based-distros.patch
which no no longer needed
@jjhelmus
update meta.yaml to 3.8.0b3
c047410
@jjhelmus
adjust search path for config static library
48cf46a
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jjhelmus
Copy link
Contributor Author

On Windows, the source for libffi_msvc has been remove and replaced by an copy of upstream libffi as of python/cpython#11797. Sources used by upstream can be found at https://github.com/python/cpython-source-deps/releases. It would be good to also review the binary dependencies available at https://github.com/python/cpython-bin-deps/releases.

@TomAugspurger TomAugspurger mentioned this pull request Aug 26, 2019
Closed
This was referenced Sep 1, 2019
Closed
Closed
h-vetinari
h-vetinari reviewed Sep 1, 2019
View reviewed changes
Copy link
Member
@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to see this moving forward!

Also, Python 3.8b4 was just released 2 days ago.

recipe/patches/0006-Support-cross-compiling-byte-code.patch
From: Ray Donnelly <mingw.android@gmail.com>
Date: Wed, 16 Aug 2017 12:17:33 +0100
Subject: [PATCH 07/20] Support cross-compiling byte-code
Subject: [PATCH 06/18] Support cross-compiling byte-code

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I was trying to rebase the patches for #261, I noticed that this patch has a bunch of calls to $(PYTHON_FOR_BUILD) that are not prefixed by $(PY_BUILD_ENVIRON). I'm guessing those cases might have been introduced upstream without the patch ever being updated, so I thought $(PY_BUILD_ENVIRON) should be added to all callsites...?

recipe/meta.yaml
- patches/0016-Unvendor-sqlite3.patch
- patches/0017-venv-Revert-a-change-from-https-github.com-python-cp.patch
# TODO re-enable
#- patches/0018-Add-CondaEcosystemModifyDllSearchPath.patch
# TODO :: Depend on our own packages for these:
- url: https://github.com/python/cpython-source-deps/archive/xz-5.2.2.zip # [win]
folder: externals/xz-5.2.2 # [win]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the build-portion of the recipe, there's still a reference to python3.7 under no_link. I (naively) tried to parametrize this, c.f. d1cf4a2.

@heavelock heavelock mentioned this pull request Sep 3, 2019
Merged
9 tasks
@h-vetinari
Copy link
Member

Python 3.8.0rc1 is scheduled in less than two weeks. I think it'd be good to grease the rails with 3.8.0b3/b4 before that?

From what I can tell, the failure in the windows job is the same one that was not considered relevant in #258.

@mariusvniekerk
Copy link
Member

@conda-forge-admin please rerender

@mariusvniekerk
Copy link
Member

Still seems to have the msbuild related issue. Should we build py38 using vs2017/2019 instead of vs2015

Error building on win64 
Build FAILED.

       "%SRC_DIR%\PCbuild\pcbuild.proj" (Build target) (1) ->
       "%SRC_DIR%\PCbuild\pythoncore.vcxproj" (Build target) (2) ->
         %SRC_DIR%\PCbuild\python.props(111,31): error MSB4086: A numeric comparison was attempted on "$([System.Version]::Parse($(_RegistryVersion)))" that evaluates to "10.0.17763.0" instead of a number, in condition "$([System.Version]::Parse($(_RegistryVersion))) > $([System.Version]::Parse($(DefaultWindowsSDKVersion)))". [%SRC_DIR%\PCbuild\pythoncore.vcxproj]

@CJ-Wright CJ-Wright mentioned this pull request Oct 14, 2019
Closed
@h-vetinari h-vetinari mentioned this pull request Oct 28, 2019
Merged
3 tasks
@mariusvniekerk
Copy link
Member

Closed by #274

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-vetinari h-vetinari h-vetinari left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jjhelmus @conda-forge-linter @h-vetinari @mariusvniekerk @conda-forge-admin
0