8000 Cleanups by h-vetinari · Pull Request #234 · conda-forge/numpy-feedstock · GitHub
[go: up one dir, main page]
Skip to content

Cleanups #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 26, 2021
Merged

Cleanups #234

merged 9 commits into from
May 26, 2021

Conversation

h-vetinari
Copy link
Member

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

The pypy builds on aarch/ppc failed several times for #233 (so new PR to fix CI seemed in order), plus I found some possibilities for clean-ups while working on #227.

Finally, there's a long-standing issues to deal better with the interaction of numpy-base from the anaconda default channels.
Fixes #142
Fixes #160
Might also solve #230

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member Author

Pypy on travis ran through, but was cutting it very close with 30 seconds to spare; let's see if some mild parallelism in the test suite can help...

@h-vetinari
Copy link
Member Author
8000 h-vetinari commented May 21, 2021

@rgommers, I fixed the pypy timeouts from #233 by skipping some of the longest-running tests (only for pypy on drone & travis). This also brought the runtime back down to having some breathing room (~20min) regarding the timeouts.

Note, this PR also (finally) adds run_constrained (cf. linked issues in OP). I think these cleanups are good to go in one, but can split into more PRs if really desired (e.g. skips, run_constrained, rest).

rgommers
rgommers reviewed May 21, 2021
View reviewed changes
Copy link
Contributor
@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @h-vetinari. Test skips look fine to me. I'm not familiar with run_constrained, so would be good to get input from @isuruf or another core member on that.

xhochy
xhochy reviewed May 21, 2021
View reviewed changes
@xhochy
Copy link
Member
xhochy commented May 21, 2021

We should also add that run_constrained as a repodata patch to all existing numpy packages.

@h-vetinari
Copy link
Member Author
h-vetinari commented May 21, 2021 •
edited
Loading

We should also add that run_constrained as a repodata patch to all existing numpy packages.

The pain seems to have been manageable thus far (issues have been open for >2 years) - I see your point, and think it's a valid approach, but wouldn't we then also run some risks of breaking currently shaky-but-running environments that mix in numpy-base?

@h-vetinari
Copy link
Member Author

Ping @isuruf

@h-vetinari h-vetinari mentioned this pull request May 25, 2021
Merged
@isuruf @xhochy
Update recipe/meta.yaml
24bead1 
Co-authored-by: Uwe L. Korn <xhochy@users.noreply.github.com>
@isuruf isuruf added the automerge Merge the PR when CI passes label May 26, 2021
@github-actions github-actions bot merged commit 9c5cc94 into conda-forge:master May 26, 2021
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • drone: passed
  • travis: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@h-vetinari h-vetinari deleted the cleanup branch May 26, 2021 20:05
@h-vetinari h-vetinari mentioned this pull request Oct 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhochy xhochy xhochy left review comments

@rgommers rgommers rgommers left review comments

@isuruf isuruf Awaiting requested review from isuruf

@jakirkham jakirkham Awaiting requested review from jakirkham

@msarahan msarahan Awaiting requested review from msarahan

@ocefpaf ocefpaf Awaiting requested review from ocefpaf

@pelson pelson Awaiting requested review from pelson

Assignees
No one assigned
Labels
automerge Merge the PR when CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add run_constrained for numpy-base 9999 Downgrading numpy from defaults -> conda-forge results in broken install
5 participants
@h-vetinari @conda-forge-linter @xhochy @rgommers @isuruf
0