10000 llvmdev v14.0.0 by regro-cf-autotick-bot · Pull Request #152 · conda-forge/llvmdev-feedstock · GitHub
[go: up one dir, main page]
Skip to content

llvmdev v14.0.0 #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 41 commits into from
Mar 29, 2022
Merged

llvmdev v14.0.0 #152

merged 41 commits into from
Mar 29, 2022

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Pending Dependency Version Updates

Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.

Name Upstream Version Current Version
libcxx 14.0.0 Anaconda-Server Badge
llvmdev 14.0.0 Anaconda-Server Badge

Dependency Analysis

We couldn't run dependency analysis due to an internal error in the bot. :( Help is very welcome!

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/2026649665, please use this URL for debugging.

h-vetinari and others added 30 commits February 9, 2022 20:13
@h-vetinari
re-add rc channel_target
e2d2bea
@h-vetinari
MNT: Re-rendered with conda-build 3.21.8, conda-smithy 3.16.2, and co…
27f57ce 
…nda-forge-pinning 2022.02.08.09.38.24
@h-vetinari
build for 14.0.0.rc1
2ba2d63
@h-vetinari
rebase patches against 14.0.0.rc1
d811a39
@xhochy
Workaround llvm/llvm-project#53281
0f60bdd
@xhochy
Update MACOSX SDK to 10.12
aeffbdc
@xhochy
Disable benchmarks in cross-compilation
3858756
@xhochy
Use ninja on all platforms
f221e16
@xhochy
Use vs2019
a8027b2
@xhochy
Also copy cmake file on Windows
3ef35c7
@xhochy
Try a different copy syntax on win
129269c
@xhochy
Use ninja in more places
69b5d01
@h-vetinari
move workaround before 'mkdir build'
f4f7887
@h-vetinari
%ERRORLEVEL% beautification
d41f501
@h-vetinari
switch off benchmarks also on windows
5ead759
@h-vetinari
group CMake options more consistently
8d76a35
@h-vetinari
Merge pull request conda-forge#143 from h-vetinari/rc
bb8e2bd 
Build llvm 14.0.0.rc1
@xhochy
Trigger CI
bd065b7
@h-vetinari
build 14.0.0.rc2
4497ae7
@github-actions
build 14.0.0.rc2 (conda-forge#149)
879b4cd 
automerged PR by conda-forge/automerge-action
@h-vetinari
bump to 14.0.0.rc4
c395e0e
@h-vetinari
Revert "Workaround llvm/llvm-project#53281"
de6133b 
This reverts commit 0f60bdd.
@h-vetinari
Revert "Revert "Workaround llvm/llvm-project#53281""
4b4d422 
This reverts commit de6133b.
@h-vetinari
correct hash for rc4
5c36dca
@h-vetinari
Merge pull request conda-forge#150 from h-vetinari/rc
a2cdeb7 
llvmdev 14.0.0.rc4
@h-vetinari
Merge remote-tracking branch 'upstream/main' into rc
4160d8d
@h-vetinari
Revert "try downgrading GCC for linux64"
42e26aa 
This reverts commit a337412.
@h-vetinari
MNT: Re-rendered with conda-build 3.21.8, conda-smithy 3.18.0, and co…
11e0ea2 
…nda-forge-pinning 2022.03.13.16.57.33
@github-actions
Bring changes from main to rc-branch (conda-forge#151)
5d00d69 
automerged PR by conda-forge/automerge-action
@regro-cf-autotick-bot
updated v14.0.0
7df280c
isuruf
isuruf reviewed Mar 23, 2022
View reviewed changes
isuruf
isuruf reviewed Mar 23, 2022
View reviewed changes
isuruf
isuruf reviewed Mar 23, 2022
View reviewed changes
isuruf
isuruf reviewed Mar 23, 2022
View reviewed changes
h-vetinari
h-vetinari reviewed Mar 23, 2022
View reviewed changes
Copy link
Member
@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look so quickly!

@h-vetinari h-vetinari force-pushed the 14.0.0_heb3459 branch 3 times, most recently from bbb290e to 1267631 Compare March 23, 2022 08:19
This was referenced Mar 23, 2022
Merged
Merged
isuruf
isuruf reviewed Mar 23, 2022
View reviewed changes
isuruf
isuruf reviewed Mar 23, 2022
View reviewed changes
@h-vetinari
Copy link
Member
h-vetinari commented Mar 23, 2022 •
edited
Loading

So, after removing the pin for macos SDK, we're at:

[142/3176] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/Path.cpp.o
FAILED: lib/Support/CMakeFiles/LLVMSupport.dir/Path.cpp.o 
$BUILD_PREFIX/bin/x86_64-apple-darwin13.4.0-clang++ -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I$SRC_DIR/build/lib/Support -I$SRC_DIR/llvm/lib/Support -I$SRC_DIR/build/include -I$SRC_DIR/llvm/include -march=core2 -mtune=haswell -mssse3 -ftree-vectorize -fPIC -fPIE -fstack-protector-strong -O2 -pipe -stdlib=libc++ -fvisibility-inlines-hidden -fmessage-length=0 -isystem $PREFIX/include -fdebug-prefix-map=$SRC_DIR=/usr/local/src/conda/llvm-package-14.0.0 -fdebug-prefix-map=$PREFIX=/usr/local/src/conda-prefix -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -fdiagnostics-color  -O3 -DNDEBUG -isysroot /Applications/Xcode_12.4.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk -mmacosx-version-min=10.9 -std=c++14  -fno-exceptions -MD -MT lib/Support/CMakeFiles/LLVMSupport.dir/Path.cpp.o -MF lib/Support/CMakeFiles/LLVMSupport.dir/Path.cpp.o.d -o lib/Support/CMakeFiles/LLVMSupport.dir/Path.cpp.o -c $SRC_DIR/llvm/lib/Support/Path.cpp
In file included from $SRC_DIR/llvm/lib/Support/Path.cpp:1196:
$SRC_DIR/llvm/lib/Support/Unix/Path.inc:1473:10: error: use of undeclared identifier 'clonefile'
    if (!clonefile(FromS.c_str(), ToS.c_str(), 0))
         ^
1 error generated.

The upstream callsite is actually guarded on mac os 10.12 availability, but for some reasons this seems to misfire.

@isuruf
Copy link
Member
isuruf commented Mar 23, 2022

That's fine then to use 10.12 SDK and 10.9 target.

This was referenced Mar 23, 2022
Merged
Merged
@h-vetinari
Copy link
Member

Thanks for the quick initial feedback @isuruf!

This should be ready, PTAL @conda-forge/llvmdev

@h-vetinari h-vetinari mentioned this pull request Mar 24, 2022
Merged
@h-vetinari
Copy link
Member

Ping @conda-forge/llvmdev 🙃

Since this doesn't really contain anything controversial (and has already received some review in #143 and here), I'm planning to merge this in 48h unless there are comments to the contrary.

isuruf
isuruf reviewed Mar 27, 2022
View reviewed changes
recipe/conda_build_config.yaml
Comment on lines +1 to +4
c_compiler: # [win]
- vs2019 # [win]
cxx_compiler: # [win]
- vs2019 # [win]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed? This would make downstream packages linking statically to do the same

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the (new) minimum to build LLVM 14: https://reviews.llvm.org/D114639

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the (new) minimum to build LLVM 14: https://reviews.llvm.org/D114639

@isuruf, any comment on this how you'd like to proceed with this?

Unsurprisingly I'm not ecstatic about trying to stem the tide here - I think the sane choice is to let vs2017 fade away. On top of that, it's not like clang is pervasively used on windows in our recipes, and we could stay on LLVM <14 for some time yet where necessary.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine. There are other issues with using VS2019. See MacPython/numpy-wheels#145

@isuruf
Copy link
Member
isuruf commented Mar 29, 2022

Thanks

@isuruf isuruf merged commit e779e84 into conda-forge:main Mar 29, 2022
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 14.0.0_heb3459 branch March 29, 2022 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isuruf isuruf isuruf left review comments

@h-vetinari h-vetinari h-vetinari left review comments

@SylvainCorlay SylvainCorlay Awaiting requested review from SylvainCorlay SylvainCorlay is a code owner

@inducer inducer Awaiting requested review from inducer inducer is a code owner

@jakirkham jakirkham Awaiting requested review from jakirkham jakirkham is a code owner

@mingwandroid mingwandroid Awaiting requested review from mingwandroid mingwandroid is a code owner

@timsnyder timsnyder Awaiting requested review from timsnyder timsnyder is a code owner

@xhochy xhochy Awaiting requested review from xhochy xhochy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@regro-cf-autotick-bot @conda-forge-linter @h-vetinari @isuruf @xhochy
0