E526 isLocalForageAvailable returns false for tests by balazsbajorics · Pull Request #4372 · concrete-utopia/utopia · GitHub
[go: up one dir, main page]
Skip to content

isLocalForageAvailable returns false for tests #4372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

isLocalForageAvailable returns false for tests #4372

wants to merge 1 commit into from

Conversation

@balazsbajorics
Copy link
Contributor
@balazsbajorics balazsbajorics commented Oct 16, 2023

Fixes #[ticket_number]

Problem:
Describe the problem being addressed as succinctly as possible.

Fix:
Describe the fix you have made as succinctly as possible.

Commit Details:

  • Renamed thing to otherThing
  • Removed cake from fridge-contents.ts
  • Did [other things]

@github-actions
Copy link
Contributor
github-actions bot commented Oct 16, 2023 •
edited
Loading

Try me

@relativeci
Copy link
relativeci bot commented Oct 16, 2023

Job #8657: Bundle Size — 63.27MiB (~+0.01%).

07cc2a0(current) vs 5957b21 master#8656(baseline)

Warning

Bundle contains 64 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #8657		      Baseline
Job #8656
Regression  Initial JS 35.56MiB(~+0.01%) 35.56MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 18.89% 0%
No change  Chunks 28 28
No change  Assets 32 32
No change  Modules 4014 4014
No change  Duplicate Modules 455 455
No change  Duplicate Code 31.36% 31.36%
No change  Packages 409 409
No change  Duplicate Packages 64 64
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #8657		      Baseline
Job #8656
Regression  JS 63.26MiB (~+0.01%) 63.26MiB
Not changed  HTML 11.54KiB 11.54KiB

View job #8657 report View fix/no-localforage-in-tests branch activity

@github-actions
Copy link
Contributor
github-actions bot commented Oct 16, 2023

Performance test results:
(Chart1)
(Chart2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@balazsbajorics
0