8000 Issue_#607: set unused command as default while not other commands ar… by MarcinGladkowski · Pull Request #608 · composer-unused/composer-unused · GitHub
[go: up one dir, main page]
Skip to content

Issue_#607: set unused command as default while not other commands ar… #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 8, 2025
Merged

Issue_#607: set unused command as default while not other commands ar… #608

merged 4 commits into from
Apr 8, 2025

Conversation

MarcinGladkowski
Copy link
Contributor
@MarcinGladkowski MarcinGladkowski commented Jan 5, 2024 •
edited
Loading

…e using

All Submissions:

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@MarcinGladkowski MarcinGladkowski mentioned this pull request Jan 5, 2024
Closed
@MarcinGladkowski
Copy link
Contributor Author
MarcinGladkowski commented Jan 5, 2024 •
edited
Loading

@icanhazstring Is it something wrong with repo secrets config ?

https://github.com/composer-unused/composer-unused/actions/runs/7419586499/job/20189374683?pr=608

@icanhazstring
Copy link
Member

Yes Kind of.
I am currently reworking the phar build and had to renew the gpg keys and stuff.

icanhazstring
icanhazstring reviewed Jan 5, 2024
View reviewed changes
@icanhazstring
Copy link
Member

@MarcinGladkowski I updated the repo.
Unfortunately, I tried your solution but it's not working.
If you have time to rebase with main and try to fix your PR. I would be happy to merge it :)

@MarcinGladkowski
Copy link
Contributor Author

@icanhazstring Hi! I've done it.

Let's look at my manual tests:
Screenshot from 2025-04-08 18-43-31

and other command...
Screenshot from 2025-04-08 18-45-55

@icanhazstring
Copy link
Member

Nice. Thank you 💪

@icanhazstring icanhazstring merged commit afa144b into composer-unused:main Apr 8, 2025
14 of 16 checks passed
@MarcinGladkowski
Copy link
Contributor Author
MarcinGladkowski commented Apr 8, 2025 •
edited
Loading

@icanhazstring If you want, I would really appreciate any other ideas to improve or add. Thanks!

@MarcinGladkowski
Copy link
Contributor Author

@icanhazstring I think the step of validating phar can be switched off for PRs, due to missing GDP keys it will fails github actions all the time.

@icanhazstring
Copy link
Member

Yep already thought the same 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icanhazstring icanhazstring icanhazstring left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcinGladkowski @icanhazstring
0