Fix phpstan when using simple-phpunit #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seldaek
reviewed
Apr 11, 2021
| @@ -36,7 +36,7 @@ | |||
| } | |||
| }, | |||
| "scripts": { | |||
| "test": "SYMFONY_PHPUNIT_REMOVE_RETURN_TYPEHINT=1 vendor/bin/simple-phpunit", | |||
| "test": "vendor/bin/simple-phpunit", | |||
There was a problem hiding this comment.
Isn't that needed for you to run the tests on latest phpunit? Like when using PHP 8 IIRC I needed this.
There was a problem hiding this comment.
I refactored the tests in #102 to work with PHPUnit8 and got round the type-hinted methods by replacing them with @before. @beforeClass etc annotated methods. So there is no need for SYMFONY_PHPUNIT_REMOVE_RETURN_TYPEHINT.
The tests run fine in PHP-8: https://github.com/composer/xdebug-handler/runs/2309173611?check_suite_focus=true
There was a problem hiding this comment.
I see, interesting workaround :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPStan cannot find PHPUnit classes when simple-phpunit is being used because they are not in the autoloader. This fix ensures that PHPUnit is installed in
vendor/bin/.phpunitand autoloads the classes.It uses the
vendor/bin/.phpunit/phpunitdirectory that simple-phpunit creates with a symlink from the installed phpunit folder. However this won't work on Windows, where you (generally) need to be an admin to create symlinks: symfony/symfony#40754