Native function and constant invocation CS #8178
Conversation
|
I saw #6777 but don't agree with not enabling it. The CS rules are not enforced by composer so it does not add a burden on contributors. And it does not add a burden on maintainers because the CS fixing is fully automated. Even if this only improves composer performance by 0.5% (others reported 5%), please be aware that composer runs everywhere (CI, developers machines, autoload on servers). So saving a little has big impact for everyone. Please also consider the power savings for the environment. One small step for composer, one giant leap for computers. |
|
Right now with the 2.0 branch in the air I am definitely not going to merge this.. Way too much conflict potential. As for saving the planet.. I am doubtful of the impact this has, but if there is an impact, 99% of it can probably be done by tweaking a couple files with hot loops, as opposed to polluting all files with useless backslashes. I don't care if it's automated, humans have to read the code still, and this doesn't do any good on that front. |
The first commit fixes the CS according to the current ruleset. The second/third adds
native_constant_invocationandnative_function_invocationfixers which could speed up composer a little. Ref. symfony/symfony#27852