Add Unicode Support #629
Add Unicode Support #629
Conversation
2133c83 to
7234936
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #629 +/- ##
==========================================
+ Coverage 97.31% 97.33% +0.02%
==========================================
Files 42 42
Lines 2045 2104 +59
==========================================
+ Hits 1990 2048 +58
- Misses 55 56 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
@adam-grant-hendry Thanks for the update! Just one minor discussion needed on my side.
@woile I'm planning on merging this next week. Let me know if you need more time to take a deeper look. Thanks!
|
LGTM, the only thing missing is documentation: https://commitizen-tools.github.io/commitizen/config/ Ideally, I think the |
|
It seems CI failed on windows 🤔 |
|
@Lee-W I didn't push any commits yesterday, but it is showing that I did through |
|
Hi @adam-grant-hendry , yes I tried to rebase the master branch to this one to see if the latest update fix this branch |
|
Is this still valid? Please rebase 🙏🏻 |
5136163 to
f028055
Compare
|
@woile @Lee-W Apologies for taking so long: I've been away for quite some time. My gpg signature keys are outdated, but the commits are by me.
Only remaining item is to add documentation. I added |
|
@adam-grant-hendry Sure! I'll take a look these days. |
No worries at all. Thank you for your review!
I probably can’t get to this today, but I can start tomorrow. I’ll see if I can request your re-review by Monday morning. Thanks again! |
e08d0d5 to
3383821
Compare
|
@Lee-W I made all the changes discussed. Please re-review this PR at your earliest convenience. Thank you! |
|
@adam-grant-hendry Sure! I'll try to take a look this weekend |
There was a problem hiding this comment.
Overall, I'm good with this PR. But we missed a few places missed. Wondering is it designed this way or just missed.
commitizen/commitizen/commands/init.py
Line 38 in 114501d
commitizen/hooks/prepare-commit-msg.py
Line 63 in 114501d
But, yep looks like they might be something not affected 🤔
I'm planning on merging this next week. @woile Please let me know if you want to take a deeper looks 🙂
|
@adam-grant-hendry ah, just notice a conflict. might need your help to resolve it. |
I purposefully left these out as I considered them "trivial" cases. By that I mean the |
|
Sounds good 👍 Just want to confirm it. I think we're good to merge it after resolving the conflict. Thanks! |
8ae25d0 to
69c90ab
Compare
This will allow commiting, e.g., emoji's and parsing commit messages for unicode characters when creating change logs.
Also, use `utf-8` by default on Windows in `out.py`.
Map `"encoding"` and `"name"` to `encoding` and `name` variables, respectively (removes hard-coding of values).
Add `encoding` parameter to `open` and `smart_open` method calls where missed. Use `defaults.encoding` as default.
093eb23 to
ecc3365
Compare
I had to pull in the latest commits to |
|
Many thanks! Just merged |
Adds unicode support by allowing configurable encodings to be specified (defaults to
utf-8).Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testFixes: Issue #516