8000 remove trailing space in keep_a_changelog and other minor improvement by Lee-W · Pull Request #190 · commitizen-tools/commitizen · GitHub
[go: up one dir, main page]
Skip to content

remove trailing space in keep_a_changelog and other minor improvement #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 23, 2020
Merged

remove trailing space in keep_a_changelog and other minor improvement #190

merged 8 commits into from
May 23, 2020

Conversation

Lee-W
Copy link
Member
@Lee-W Lee-W commented May 23, 2020

(Thanks for sending a pull request! Please fill in the following content to let us know better about this change.)

Types of changes

Please put an x in the box that applies

  • Bugfix
  • New feature
  • Refactoring
  • Breaking change (any change that would cause existing functionality to not work as expected)
  • Documentation Update
  • Other (please describe): ci improvement

Description

  • Refactoring
    • unify docstring style to google convetion
    • fix typo in codebase (through codespell)
  • fix
    • remove trailing space in keep_a_changelog
  • doc
    • add pypa/gh-action-pypi-publish as reference
  • ci improvement
    • use pydocstyle to check docstring style
    • add commit check

Checklist:

  • Add test cases to all the changes you introduce
  • Run ./script/lint and ./script/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Steps to Test This Pull Request

  1. Generate changelog through cz changelog

Expected behavior

The trailing space after each version should no longer exist.

Related Issue

#161

Additional context

@Lee-W Lee-W force-pushed the unify-docstring-style branch 3 times, most recently from c2c846c to bc24768 Compare May 23, 2020 09:02
@woile
Copy link
Member
woile commented May 23, 2020

coool 👍

@codecov
Copy link
codecov bot commented May 23, 2020 •
edited
Loading

Codecov Report

Merging #190 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #190   +/-   ##
=======================================
  Coverage   92.14%   92.14%           
=======================================
  Files          35       35           
  Lines         967      967           
=======================================
  Hits          891      891           
  Misses         76       76
Flag Coverage Δ
#unittests 92.14% <100.00%> (ø)
Impacted Files Coverage Δ
commitizen/changelog_parser.py 96.92% <ø> (ø)
commitizen/cli.py 91.17% <ø> (ø)
commitizen/commands/check.py 100.00% <ø> (ø)
commitizen/config/__init__.py 81.81% <ø> (ø)
commitizen/cz/base.py 96.77% <ø> (ø)
commitizen/factory.py 100.00% <ø> (ø)
commitizen/git.py 95.18% <ø> (ø)
commitizen/commands/bump.py 88.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5201aaf...274179f. Read the comment docs.

@Lee-W Lee-W force-pushed the unify-docstring-style branch from 7b9b7a8 to 11f5d8e Compare May 23, 2020 09:37
@Lee-W
ci(github-action): fix commit check error
274179f 
* load the full commit log when checkout
* do not raise error if no commit to check (e.g. master branch)
@Lee-W Lee-W force-pushed the unify-docstring-style branch from 11f5d8e to 274179f Compare May 23, 2020 09:39
@Lee-W Lee-W merged commit a47628e into master May 23, 2020
@Lee-W Lee-W deleted the unify-docstring-style branch June 5, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lee-W @woile
0