8000 refactor(changelog): minor cleanup by bearomorphism · Pull Request #1443 · commitizen-tools/commitizen · GitHub
[go: up one dir, main page]
Skip to content

refactor(changelog): minor cleanup #1443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2025
Merged

refactor(changelog): minor cleanup #1443

merged 1 commit into from
May 23, 2025

Conversation

bearomorphism
Copy link
Contributor
@bearomorphism bearomorphism commented May 19, 2025 •
edited
Loading

Description

Checklist

Code Changes

  • Add test cases to all the changes you introduce
  • Run poetry all locally to ensure this change passes linter check and tests
  • Manually test the changes:
    • Verify the feature/bug fix works as expected in real-world scenarios
    • Test edge cases and error conditions
    • Ensure backward compatibility is maintained
    • Document any manual testing steps performed
  • Update the documentation for the changes

Documentation Changes

  • Run poetry doc locally to ensure the documentation pages renders correctly

Expected Behavior

Steps to Test This Pull Request

Additional Context

@codecov Codecov
Copy link
codecov bot commented May 19, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (refactors@e3b4465). Learn more about missing BASE report.

Additional details and impacted files 
@@             Coverage Diff              @@
##             refactors    #1443   +/-   ##
============================================
  Coverage             ?   97.66%           
============================================
  Files                ?       57           
  Lines                ?     2615           
  Branches             ?        0           
============================================
  Hits                 ?     2554           
  Misses               ?       61           
  Partials             ?        0
Flag Coverage Δ
unittests 97.66% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bearomorphism bearomorphism force-pushed the refactor-changelog-3 branch from 4dd7249 to 5d562c7 Compare May 19, 2025 17:09
Lee-W
Lee-W reviewed May 22, 2025
View reviewed changes
commitizen/commands/changelog.py Outdated
tag_ratio = map(
lambda tag: (
SequenceMatcher(
items = (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
items = (
scores_and_tag_names: Generator[tuple[int, str]] = (

might be a better name. items is too broad

Lee-W
Lee-W reviewed May 22, 2025
View reviewed changes
Copy link
Member
@Lee-W Lee-W left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good, one nitpick. I just found out we bump versions too frequently. We didn't expect contributions this many and this fast. Thanks so much. But I just create a refactors branch and will point these PRs to that one and merge them all at once

@Lee-W Lee-W changed the base branch from master to refactors May 22, 2025 03:23
@bearomorphism bearomorphism force-pushed the refactor-changelog-3 branch from 5d562c7 to 13a7717 Compare May 22, 2025 14:24
@Lee-W Lee-W merged commit a51e706 into commitizen-tools:refactors May 23, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lee-W Lee-W Lee-W approved these changes

@woile woile Awaiting requested review from woile woile is a code owner

@noirbizarre noirbizarre Awaiting requested review from noirbizarre noirbizarre is a code owner

Assignees
No one assigned
Labels
pr-status: wait-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bearomorphism @Lee-W
0