8000
Bump color-rgba 2.1.1 - module color-normalize #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that one test is not compatible with current "stable" node version 12.3.1. |
1 task
|
@archmoj do you have an idea why tests are failing in node 12? |
|
@dy could you possibly release a patch from this? |
|
Looks good to me. I'd merge it, but I'm not an owner of the npm package. |
|
@dy any chance we have a patch release this week? |
dy
reviewed
Jun 25, 2019
| @@ -1,14 +1,21 @@ | |||
| const assert = require('assert') | |||
| const rgba = require('./') | |||
|
|
|||
| function assert_deepEqual(a, b) { | |||
There was a problem hiding this comment.
@archmoj what was the cause for this method?
|
Sorry for the delay. Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include fix for colorjs/color-parse#1
@dy
cc: @etpinard