8000 Remove item viewer constraints by byfnoel · Pull Request #18 · collie-reader/collie · GitHub
[go: up one dir, main page]

Skip to content

Remove item viewer constraints#18

Merged
parksb merged 3 commits intocollie-reader:mainfrom
byfnoel:larger-item-viewer
May 1, 2025
Merged

Remove item viewer constraints#18
parksb merged 3 commits intocollie-reader:mainfrom
byfnoel:larger-item-viewer

Conversation

@byfnoel
Copy link
Contributor
@byfnoel byfnoel commented Apr 29, 2025

This change allows the item viewer panel to take approximately 3/4 of the screen.

See this commit for context.

This change allows the item viewer panel to take approximately 3/4 of the
screen.
@byfnoel byfnoel marked this pull request as ready for review April 29, 2025 13:44
The app was failing to build on mac. I update the dependencies that was
causing the issues.
@byfnoel
Copy link
Contributor Author
byfnoel commented Apr 30, 2025

cc: @parksb
One of the workflow in the pipeline was failing. I update the dependencies that was causing the issue.
I believe(hope) all checks will be successful now.

}

div.items-page div.item-list > ul {
div.items-page div.item-list>ul {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you revert the whitespace changes in this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review @parksb. The whitespaces applied automatically based on my editor settings.

Do you want me to revert the whitespaces back to how it was on my initial commit or you don't want whitespaces at all?

For example:
Do you want A:
8000 div.items-page div.item-list > ul {

or B:
div.items-page div.item-list>ul {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant that you should add spaces on both sides of the >, like A.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I think it should be fine now.

@parksb
Copy link
Member
parksb commented 8000 May 1, 2025

Thank you :)

@parksb parksb merged commit 61b257f into collie-reader:main May 1, 2025
3 checks passed
@byfnoel
Copy link
Contributor Author
byfnoel commented May 1, 2025

Happy this was merged!

@byfnoel byfnoel deleted the larger-item-viewer branch May 1, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0