Add support to patch sources after download #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 6, 2025
zsimic
reviewed
Feb 14, 2025
| if patches := self.cfg_patches(): | ||
| for patch in patches: | ||
| if runez.DRYRUN: | ||
| print(f"Would apply patch: {patch}") |
There was a problem hiding this comment.
Minor: looks like patch_file() was naturally never called before in dryrun mode, but this could go in the patch_file() function itself (so that other places don't have to do/repeat if dryrun)
|
Agreed, sometimes you just have to patch :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature enables us to address this issue in python's upstream configure scripts:
fixes #58
I know the readme says it's a guideline to not patch. I suppose that makes sense for the project not to patch anything out of the box. However, adding this feature seems reasonable and sensible.