8000 Allow login form to define a custom field_name as a class attribute by codingjoe · Pull Request #84 · codingjoe/django-mail-auth · GitHub
[go: up one dir, main page]
Skip to content

Allow login form to define a custom field_name as a class attribute #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2022
Merged

Allow login form to define a custom field_name as a class attribute #84

merged 1 commit into from
Dec 5, 2022

Conversation

codingjoe
Copy link
Owner

No description provided.

@codecov
Copy link
codecov bot commented Dec 5, 2022

Codecov Report

Base: 99.69% // Head: 100.00% // Increases project coverage by +0.30% 🎉

Coverage data is based on head (06e5fb5) compared to base (746ccaa).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main       #84      +/-   ##
===========================================
+ Coverage   99.69%   100.00%   +0.30%     
===========================================
  Files          21        18       -3     
  Lines         332       294      -38     
===========================================
- Hits          331       294      -37     
+ Misses          1         0       -1
Flag Coverage Δ
3.10 91.49% <100.00%> (?)
3.11 91.49% <100.00%> (?)
3.9 91.43% <100.00%> (?)
postgres 90.13% <95.23%> (?)
wagtail 98.63% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mailauth/contrib/user/admin.py 100.00% <100.00%> (ø)
...0005_emailuser_email_hash_alter_emailuser_email.py 100.00% <100.00%> (ø)
mailauth/contrib/user/models.py 100.00% <100.00%> (ø)
mailauth/contrib/user/signals.py 100.00% <100.00%> (ø)
mailauth/forms.py 100.00% <100.00%> (ø)
mailauth/signing.py 100.00% <100.00%> (ø)
mailauth/views.py
mailauth/urls.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@codingjoe codingjoe merged commit ea0c43b into main Dec 5, 2022
@codingjoe codingjoe deleted the phone branch December 5, 2022 18:05
@amureki
Copy link
Collaborator
amureki commented Dec 5, 2022

@codingjoe great feature, thanks for adding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codingjoe @amureki
0