chore: add volunteer AldrinSeanPereira#79
chore: add volunteer AldrinSeanPereira#79AldrinSeanPereira wants to merge 7 commits intocodewithvoid:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
data/users/AldrinSeanPereira.json
Outdated
| { | ||
| "name": "Aldrin Sean Pereira", | ||
| "bio": "Software Engineer", | ||
| "image": "", |
There was a problem hiding this comment.
Hey you missed the image URL.
Here is your GitHub's avatar URL https://avatars.githubusercontent.com/u/54813708?v=4 you can use it.
data/users/AldrinSeanPereira.json
Outdated
| "image": "", | ||
| "categories": [ | ||
| { | ||
| "slug": "programming | software-development", |
There was a problem hiding this comment.
Only one slug should be added!
data/users/AldrinSeanPereira.json
Outdated
| "categories": [ | ||
| { | ||
| "slug": "programming | software-development", | ||
| "topics": [] |
There was a problem hiding this comment.
Add topics which you are good at like javascript or python
|
Thanks for volunterring @AldrinSeanPereira :). PTAL at @RakeshSangem's comments. |
There was a problem hiding this comment.
I have corrected my PR. Thanks to the reviewers for taking the time to help!!
@RakeshSangem @codewithvoid
data/users/AldrinSeanPereira.json
Outdated
| { | ||
| "name": "Aldrin Sean Pereira", | ||
| "bio": "Software Engineer", | ||
| "image": "C:\Users\admin\Downloads\20220704_154207.jpg", |
There was a problem hiding this comment.
can you use github image url here like
https://avatars.githubusercontent.com/u/54813708?v=4
|
@AldrinSeanPereira added small comments. PTAL. |
|
got it. thank you @codewithvoid 🥰❤️ |
specified only programming languages
There was a problem hiding this comment.
New changes made according to @codewithvoid's suggestions :)
| "image": "https://avatars.githubusercontent.com/u/54813708?v=4", | ||
| "categories": [ | ||
| { | ||
| "slug": "software-development", |
| "categories": [ | ||
| { | ||
| "slug": "software-development", | ||
| "topics": [C, C#, Python] |
There was a problem hiding this comment.
this needs to be in quotes to be in valid json
"topics": ["C", "C#", "Python"]
I'd like to make my first PR with this wonderful project!