We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up GitHub Actions to run tests to check the PRs on GitHub.
I add YAML file to define workflow.
#1685
CI will help maintainer, contributors and users of CodeTriage to know the code work well, or alert soon when something is broken.
I created the same PR to another forked repo ( gregmolnar#1 ), and run CI. GitHub actions are triggered by pushing, and all jobs are success.
Sorry, something went wrong.
9560ec7
bd14aeb
@schneems I think you need to allow the checks to be run.
c9aa0ad
cf6f011
When I gain permission to run CI, it's found that CI fails on this PR gregmolnar#1 with @gregmolnar.
I need keep trying to accomplish set up. @gregmolnar will help me in need. Thank you 😄 This PR is open but not be finished. I'll mention when I finish it.
@schneems Anyway please allow the checks to be run👍
b8e9389
ef83527
This is really exciting. Thank you for working on this!
I'm not actually sure how to do that. I don't have any options in the UI. I think because there's not an existing GitHub action in the project, it's not triggering for you to add one.
I see two options for moving forward: I can just merge this as is, and then you can fix it up if there are any errors or bugs. Alternatively, I could merge in an empty (or close to empty) GitHub action and see if that allows me to approve your CI run. The downside of that option is it would probably result in merge conflicts for you.
I don't know if @deepakmahakale has some suggestions or ideas.
@schneems
Thank you so much for your comment and advices to go forward!
Do you see 'settings' tab on this repo page? You might be change any setting at Settings > Actions > general > Fork pull request workflows from outside collaborators . (Maybe, I just guess.)
Settings > Actions > general > Fork pull request workflows from outside collaborators
I can just merge this as is, and then you can fix it up if there are any errors or bugs.
I agree this way. If you so, I'll the commits get into one before you merge. I already know all tests pass with Ruby 3.0 and 3.1 but some fails with 2.7 like this. I think this failures are because of keyword arguments. I haven't fixed and don't know how to fix it yet but I'll keep going on.
3828b0d
e983139
Yes, @neko314 is correct. Found this article that says the same - https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#controlling-changes-from-forks-to-workflows-in-public-repositories
By default, all first-time contributors require approval to run workflows.
I already know all tests pass with Ruby 3.0 and 3.1 but some fails with 2.7
We can bump the minimum Ruby version in the Gemfile instead. I don’t need to support running this under 2.7.
The ruby versions are flexible to make testing with newer Ruby versions easier. It really only needs to run on the Ruby version in the Gemfile.lock
@schneems once Ruby 2.7 is removed from the test matrix, you can just merge the PR and the checks will run.
Thanks everyone!
I'll remove 2.7 from matrix, beautify commits, then this PR will actually be almost accomplished.
Port tests over to GitHub Actions
f4751a3
Co-authored-by: gregmolnar <molnargerg@gmail.com>
f5e96d9
I've done them and I reviewed these changes by my self. Please review this PR again. Thank you in advance.
02e1aab
Thank you for your work here! Merging in 🚀
Btw looks like tests are firing just fine for me. Thanks for your work!
Successfully merging this pull request may close these issues.