8000 Update pre-commit version in documentation by prchoward · Pull Request #3666 · codespell-project/codespell · GitHub
[go: up one dir, main page]

Skip to content

Update pr 8000 e-commit version in documentation#3666

Merged
larsoner merged 1 commit intocodespell-project:mainfrom
prchoward:update-precommit-suggestion
Mar 13, 2025
Merged

Update pre-commit version in documentation#3666
larsoner merged 1 commit intocodespell-project:mainfrom
prchoward:update-precommit-suggestion

Conversation

@prchoward
Copy link
Contributor
@prchoward prchoward commented Mar 12, 2025

Closes: #3662 Update user documentation

Update the version of pre-commit in the documentation from v2.2.4 to v2.4.1 to align with current standards. The previous change was 2 years ago.

Changed the versioning outlined user documentation for precommit from v2.2.4 to
v2.4.1 to reflect modern standards
@prchoward
Copy link
Contributor Author

This is my first opensource contribution so feedback on contribution etiquette or standards is greatly appreciated.

@DimitriPapadopoulos
Copy link
Collaborator
DimitriPapadopoulos commented Mar 12, 2025

While it doesn't sound reasonable to automate such updates, we could add a comment in the pre-commit config file. It would remind us to update the README together with the pre-commit config file:

- repo: https://github.com/codespell-project/codespell
rev: v2.4.1

-   rev: v2.4.1
+   rev: v2.4.1  # update README.rst accordingly

@DimitriPapadopoulos
Copy link
Collaborator

@larsoner Same problem again with stalled checks displaying "Expected — Waiting for status to be reported". The strange thing is that these stalled checks are sort of duplicates with different full names: the stalled check displays only the the job name 3.8, while the successful check displays the full name combining the action name Pytest and the job name 3.8.

According to Github actions: Stuck in "Expected — Waiting for status to be reported", these failures could be caused by cancel-in-progress:

cancel-in-progress: true

There doesn't seem to be a solution other than removing cancel-in-progress.

Unless of course there is a discrepancy between branch protection rules and actual job names, but that would result in consistent errors for each PR, wouldn't it?

@larsoner
Copy link
Member

The cancel-in-progress would be weird... the jobs actually ran and had the correct names. I have a different more hacky solution that I think should work, I'll open a PR shortly

@larsoner larsoner merged commit da0e111 into codespell-project:main Mar 13, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suggested pre-commit version is ancient

3 participants

0