10000 Ean Search added by littleyoda · Pull Request #8 · codesalatdev/python-picnic-api · GitHub
[go: up one dir, main page]
Skip to content

Ean Search added #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Ean Search added #8

wants to merge 1 commit into from

Conversation

littleyoda
Copy link

A PR which allows you to search for scanned EAN/Gtin on Picnic.

from python_picnic_api2.client import PicnicAPI
p = PicnicAPI("XXX","YYY",'de');
id = p.get_product_from_gtin("4037300108293")
picnic.add_product(id)

@codesalatdev codesalatdev added the enhancement New feature or request label Apr 21, 2025
@codecov Codecov
Copy link
codecov bot commented Apr 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 7.14286% with 13 lines in your changes missing coverage. Please review.

Project coverage is 64.31%. Comparing base (60f5f42) to head (cd7b051).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/python_picnic_api2/client.py 7.14% 13 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
- Coverage   68.07%   64.31%   -3.76%     
==========================================
  Files           4        4              
  Lines         213      227      +14     
==========================================
+ Hits          145      146       +1     
- Misses         68       81      +13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codesalatdev
Copy link
Owner

This is cool!

There's tests missing tho and I would like to change the wording a bit (product -> article). Let me know whether you want to continue working on this PR or if I should take over.

Thank you!

@littleyoda
Copy link
Author

You are welcome to take over the PR. I think that will get you there faster than if we first clarify what you want to have changed.

@codesalatdev codesalatdev mentioned this pull request Apr 28, 2025
Merged
@codesalatdev
Copy link
Owner

Superseeded by #11. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@littleyoda @codesalatdev
0