8000 docs(error/$compile.baddir): mention "components" in directive name e… · coderofsalvation/angular.js@33f3c40 · GitHub
[go: up one dir, main page]

Skip to content
8000

Commit 33f3c40

Browse files
pmadrugagkalpak
authored andcommitted
docs(error/$compile.baddir): mention "components" in directive name error
Closes angular#14212
1 parent 696cb95 commit 33f3c40

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
@ngdoc error
22
@name $compile:baddir
3-
@fullName Invalid Directive Name
3+
@fullName Invalid Directive/Component Name
44
@description
55

6-
This error occurs when the name of a directive is not valid.
6+
This error occurs when the name of a directive or component is not valid.
77

8-
Directives must start with a lowercase character and must not contain leading or trailing whitespaces.
8+
Directives and Components must start with a lowercase character and must not contain leading or trailing whitespaces.

src/ng/compile.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -928,11 +928,11 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
928928
function assertValidDirectiveName(name) {
929929
var letter = name.charAt(0);
930930
if (!letter || letter !== lowercase(letter)) {
931-
throw $compileMinErr('baddir', "Directive name '{0}' is invalid. The first character must be a lowercase letter", name);
931+
throw $compileMinErr('baddir', "Directive/Component name '{0}' is invalid. The first character must be a lowercase letter", name);
932932
}
933933
if (name !== name.trim()) {
934934
throw $compileMinErr('baddir',
935-
"Directive name '{0}' is invalid. The name should not contain leading or trailing whitespaces",
935+
"Directive/Component name '{0}' is invalid. The name should not contain leading or trailing whitespaces",
936936
name);
937937
}
938938
}

test/ng/compileSpec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ describe('$compile', function() {
206206
module(function() {
207207
expect(function() {
208208
directive('BadDirectiveName', function() { });
209-
}).toThrowMinErr('$compile','baddir', "Directive name 'BadDirectiveName' is invalid. The first character must be a lowercase letter");
209+
}).toThrowMinErr('$compile','baddir', "Directive/Component name 'BadDirectiveName' is invalid. The first character must be a lowercase letter");
210210
});
211211
inject(function($compile) {});
212212
});
@@ -216,7 +216,7 @@ describe('$compile', function() {
216216
expect(function() {
217217
directive(name, function() { });
218218
}).toThrowMinErr(
219-
'$compile','baddir', 'Directive name \'' + name + '\' is invalid. ' +
219+
'$compile','baddir', 'Directive/Component name \'' + name + '\' is invalid. ' +
220220
"The name should not contain leading or trailing whitespaces");
221221
}
222222
assertLeadingOrTrailingWhitespaceInDirectiveName(' leadingWhitespaceDirectiveName');

0 commit comments

Comments
 (0)
0