8000 refactor($compile): added component text when asserting directive name by pmadruga · Pull Request #14212 · angular/angular.js · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

refactor($compile): added component text when asserting directive name #14212

Closed
wants to merge 2 commits into from
Closed

refactor($compile): added component text when asserting directive name #14212

wants to merge 2 commits into from

Conversation

pmadruga
Copy link
Contributor
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Considering the Angular 1.5 introduction of components, when creating a component with an uppercase, the error thrown mentions a directive. This fix/update will provide the user information for when he has created an uppercased component (in general terms, not differentiating between directive and component).
  • What is the current behavior? (You can also link to an open issue here)
    The error thrown includes the text: Directive name 'ThisExample' is invalid. The first character must be a lowercase letter
  • What is the new behavior (if this is a feature change)?
    The error thrown includes the text: Directive/Component name 'ThisExample' is invalid. The first character must be a lowercase letter
  • Does this PR introduce a breaking change?
    No.
  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Other information:

@gkalpak
Copy link
Member
gkalpak commented Mar 10, 2016

Could you also update the contents of the actual error page: https://github.com/angular/angular.js/blob/master/docs/content/error/%24compile/baddir.ngdoc ?

Other than that, it LGTM 👍

@gkalpak gkalpak added this to the 1.5.x milestone Mar 10, 2016
@pmadruga
Copy link
Contributor Author

Here you go, @gkalpak.

@gkalpak gkalpak closed this in f01d6f2 Mar 23, 2016
gkalpak pushed a commit that referenced this pull request Mar 23, 2016
@gkalpak
docs(error/$compile.baddir): mention "components" in directive name e…
33f3c40 
…rror

Closes #14212
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes component: $compile frequency: low needs: work severity: confusing type: docs
Projects
None yet
Milestone
1.5.x
Development

Successfully merging this pull request may close these issues.
3 participants
@pmadruga @gkalpak @googlebot
0