forked from bazelbuild/bazel
-
Notifications
You must be signed in to change notification settings - Fork 0
{{ message }}
Improve test coverage of remote worker files #2
+81
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a runfiles tree to the input and also runs the test with path mapping enabled.
…mote worker files
Collaborator
Author
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
WalkthroughThe changes introduce a new dependency to the test build configuration, specifically adding Changes
Sequence Diagram(s)sequenceDiagram
participant TestRunner
participant RemoteExecutionServiceTest
participant Spawn
participant PathMapper
participant MerkleTree
TestRunner->>RemoteExecutionServiceTest: buildRemoteActionForRemotePersistentWorkers(enablePathMapping)
RemoteExecutionServiceTest->>Spawn: Create spawn with inputs, tools, runfiles tree
alt enablePathMapping is true
RemoteExecutionServiceTest->>PathMapper: Apply prefix mapping to paths
else enablePathMapping is false
RemoteExecutionServiceTest->>PathMapper: No-op mapping
end
RemoteExecutionServiceTest->>MerkleTree: Build Merkle tree including runfiles and tool
RemoteExecutionServiceTest->>RemoteExecutionServiceTest: Assert persistent worker key and Merkle structure
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ast-grep (0.31.1)src/test/java/com/google/devtools/build/lib/remote/RemoteExecutionServiceTest.java📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🧰 Additional context used🧬 Code Graph Analysis (1)src/test/java/com/google/devtools/build/lib/remote/RemoteExecutionServiceTest.java (2)
🔇 Additional comments (9)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Collaborator
Author
|
/codehelper |
Collaborator
Author
|
/refacto-test |
|
Refacto is reviewing this PR. Please wait for the review comments to be posted. |
| nodeFoo2.toNode(), PathFragment.EMPTY_FRAGMENT, PathMapper.NOOP.getClass()), | ||
| ImmutableList.of( | ||
| nodeBar.toNode(), PathFragment.EMPTY_FRAGMENT, PathMapper.NOOP.getClass())); | ||
| } |
There was a problem hiding this comment.
Test Design: This test method has grown quite large (over 100 lines) and now handles multiple test scenarios with the new enablePathMapping parameter. Consider breaking it down into smaller, more focused test methods for better readability and maintainability. This would make failures more specific and easier to debug.
| nodeFoo2.toNode(), PathFragment.EMPTY_FRAGMENT, PathMapper.NOOP.getClass()), | ||
| ImmutableList.of( | ||
| nodeBar.toNode(), PathFragment.EMPTY_FRAGMENT, PathMapper.NOOP.getClass())); | ||
| } |
There was a problem hiding this comment.
Test Naming: Now that this test method accepts a parameter to test different scenarios (with and without path mapping), consider renaming it to better reflect its parameterized nature. A name like buildRemoteActionForRemotePersistentWorkersWithPathMapping would more clearly communicate the test's purpose.
| return PathFragment.create(root); | ||
| } | ||
|
|
||
| @Override |
There was a problem hiding this comment.
Code Complexity: This lambda expression contains nested method calls spanning multiple lines, making it difficult to understand at a glance. Consider extracting this mapping logic to a named helper method to improve readability and make the intent clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a runfiles tree to the input and also runs the test with path mapping enabled.
Summary by CodeRabbit