8000 chore: simplify prettier config by aslilac · Pull Request #528 · coder/vscode-coder · GitHub
[go: up one dir, main page]

Skip to content

chore: simplify prettier config #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 5, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
actually, y'know what? no half measures
  • Loading branch information
aslilac committed Jun 5, 2025
commit 7bf97f904a2579f06eb9a701a951ae8dcfbf40cd
6 changes: 4 additions & 2 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
root = true

[*]
indent_style = space
trim_trailing_whitespace = true
end_of_line = lf
indent_size = 2
indent_style = tab
insert_final_newline = true
trim_trailing_whitespace = true
115 changes: 58 additions & 57 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,59 +1,60 @@
{
"root": true,
"parser": "@typescript-eslint/parser",
"parserOptions": {
"ecmaVersion": 6,
"sourceType": "module"
},
"plugins": [
"@typescript-eslint",
"prettier"
],
"extends": [
"eslint:recommended",
"plugin:@typescript-eslint/recommended",
"plugin:import/recommended",
"plugin:import/typescript",
"plugin:md/prettier",
"prettier"
],
"overrides": [{
"files": ["*.md"],
"parser": "markdown-eslint-parser"
}],
"rules": {
"curly": "error",
"eqeqeq": "error",
"no-throw-literal": "error",
"no-console": "error",
"prettier/prettier": "error",
"import/order": ["error", {
"alphabetize": {
"order": "asc"
},
"groups": [["builtin", "external", "internal"], "parent", "sibling"]
}],
"import/no-unresolved": ["error", {
"ignore": ["vscode"]
}],
"@typescript-eslint/no-unused-vars": [
"error",
{
"varsIgnorePattern": "^_"
}
],
"md/remark": [
"error",
{
"no-duplicate-headings": {
"sublings_only": true
}
}
]
},
"ignorePatterns": [
"out",
"dist",
"**/*.d.ts"
]
"root": true,
"parser": "@typescript-eslint/parser",
"parserOptions": {
"ecmaVersion": 6,
"sourceType": "module"
},
"plugins": ["@typescript-eslint", "prettier"],
"extends": [
"eslint:recommended",
"plugin:@typescript-eslint/recommended",
"plugin:import/recommended",
"plugin:import/typescript",
"plugin:md/prettier",
"prettier"
],
"overrides": [
{
"files": ["*.md"],
"parser": "markdown-eslint-parser"
}
],
"rules": {
"curly": "error",
"eqeqeq": "error",
"no-throw-literal": "error",
"no-console": "error",
"prettier/prettier": "error",
"import/order": [
"error",
{
"alphabetize": {
"order": "asc"
},
"groups": [["builtin", "external", "internal"], "parent", "sibling"]
}
],
"import/no-unresolved": [
"error",
{
"ignore": ["vscode"]
}
],
"@typescript-eslint/no-unused-vars": [
"error",
{
"varsIgnorePattern": "^_"
}
],
"md/remark": [
"error",
{
"no-duplicate-headings": {
"sublings_only": true
}
}
]
},
"ignorePatterns": ["out", "dist", "**/*.d.ts"]
}
2 changes: 2 additions & 0 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ jobs:

- run: yarn

- run: yarn prettier --check .

- run: yarn lint

- run: yarn build
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: '18'
node-version: "18"

- run: yarn

Expand Down
9 changes: 9 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
/dist/
/node_modules/
/out/
/.vscode-test/
/.nyc_output/
/coverage/
*.vsix
flake.lock
yarn-error.log
16 changes: 0 additions & 16 deletions .prettierrc

This file was deleted.

20 changes: 10 additions & 10 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
{
"version": "0.2.0",
"configurations": [
{
"name": "Run Extension",
"type": "extensionHost",
"request": "launch",
"args": ["--extensionDevelopmentPath=${workspaceFolder}"],
"outFiles": ["${workspaceFolder}/dist/**/*.js"]
}
]
"version": "0.2.0",
"configurations": [
{
"name": "Run Extension",
"type": "extensionHost",
"request": "launch",
"args": ["--extensionDevelopmentPath=${workspaceFolder}"],
"outFiles": ["${workspaceFolder}/dist/**/*.js"]
}
]
}
6 changes: 2 additions & 4 deletions .vscode/tasks.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,9 @@
{
"type": "typescript",
"tsconfig": "tsconfig.json",
"problemMatcher": [
"$tsc"
],
"problemMatcher": ["$tsc"],
"group": "build",
"label": "tsc: build"
}
]
}
}
Loading
Loading
0