8000 Comparing e35030b...6137223 · coder/terraform-provider-envbuilder · GitHub
[go: up one dir, main page]

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: coder/terraform-provider-envbuilder
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e35030b
Choose a base ref
...
head repository: coder/terraform-provider-envbuilder
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6137223
Choose a head ref
  • 3 commits
  • 9 files changed
  • 1 contributor

Commits on Sep 4, 2024

  1. fix(internal/provider): correctly override from extra_env (#44)

    Relates to #43
    
    Our previous logic did not pass options from extra_env to envbuilder.RunCacheProbe.
    This fixes the logic and adds more comprehensive tests around the overriding logic.
    Future commits will refactor this logic some more.
    johnstcn authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    23f2cf5 View commit details
    Browse the repository at this point in the history
  2. chore(internal/provider): refactor cached_image_resource (#46)

    Addresses some non-blocking comments from #44:
    
    - Extracts some of the functions in cached_image_resource.go to separate internal packages tfutil and imgutil.
    - Some other functions are extracted to helpers.go.
    - Extracts non-overridable flags to a package-level variable.
    - Pre-allocates some slices where possible.
    - Removes some unused code and renames some existing code for readability
    johnstcn authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    482a446 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Configuration menu
    Copy the full SHA
    6137223 View commit details
    Browse the repository at this point in the history
Loading
0