8000 fix: stop selecting direct connections with too-small MTU by spikecurtis · Pull Request #85 · coder/tailscale · GitHub
[go: up one dir, main page]
Skip to content

fix: stop selecting direct connections with too-small MTU #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 10, 2025
+208 −12
Merged

fix: stop selecting direct connections with too-small MTU #85

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bede4fb
feat: pad disco ping/pong and enable path mtu on Windows
spikecurtis Jun 9, 2025
1bab46f
feat: set path MTU discover on Linux
spikecurtis Jun 9, 2025
ef3f81d
feat: set IP_DONTFRAG on macOS
spikecurtis Jun 9, 2025
c89c6b7
logs and comments
spikecurtis Jun 9, 2025
4686156
fix: check Disco Ping/Pong length in unit tests
spikecurtis Jun 10, 2025
6923084
restyle constant defs on Windows
spikecurtis Jun 10, 2025
b824a9c
make ping/pong test explicit
spikecurtis Jun 10, 2025
4ec7ef5
import ordering
spikecurtis Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: set IP_DONTFRAG on macOS
  • Loading branch information
@spikecurtis
spikecurtis committed Jun 9, 2025
commit ef3f81d39f70361a38d69c2bcb30cf3f754365a0
6 changes: 3 additions & 3 deletions wgengine/magicsock/magicsock_darwin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@ func trySetPathMTUDiscover(pconn nettype.PacketConn, logf logger.Logf, network s
logf("magicsock: failed to set Path MTU Discover: get syscall conn: %v", err)
}
level := unix.IPPROTO_IP
option := unix.IP_MTU_DISCOVER
option := unix.IP_DONTFRAG
if network == "udp6" {
level = unix.IPPROTO_IPV6
option = unix.IPV6_MTU_DISCOVER
option = unix.IPV6_DONTFRAG
}
err = s.Control(func(fd uintptr) {
err := unix.SetsockoptInt(int(fd), level, option, unix.IP_PMTUDISC_DO)
err := unix.SetsockoptInt(int(fd), level, option, 1)
if err != nil {
logf("magicsock: failed to set Path MTU Discover: SetsockoptInt failed: %v", err)
}
Expand Down
0